From b4703d67c38f4ba9405ff1bfaa44ed4d5f30b109 Mon Sep 17 00:00:00 2001 From: Alexis Saettler Date: Sun, 25 Feb 2024 12:46:46 +0100 Subject: [PATCH] fix: fix jsonLdSchema (#67) --- app/Http/ViewModels/Names/NameViewModel.php | 5 +++-- resources/views/names/show.blade.php | 10 +++++----- tests/Unit/ViewModels/Names/NameViewModelTest.php | 3 ++- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/app/Http/ViewModels/Names/NameViewModel.php b/app/Http/ViewModels/Names/NameViewModel.php index 639a0f0..bde9b37 100644 --- a/app/Http/ViewModels/Names/NameViewModel.php +++ b/app/Http/ViewModels/Names/NameViewModel.php @@ -100,8 +100,9 @@ public static function jsonLdSchema(Name $name): array { return [ 'headline' => 'Tout savoir sur le prénom ' . StringHelper::formatNameFromDB($name->name), - 'image' => env('APP_URL') . '/img/facebook.png', - 'date' => Carbon::now()->format('Y-m-d'), + 'image' => asset('/img/facebook.png'), + 'updated_at' => $name->updated_at->format('Y-m-d'), + 'created_at' => $name->updated_at->format('Y-m-d'), 'url' => route('name.show', [ 'id' => $name->id, 'name' => StringHelper::sanitizeNameForURL($name->name), diff --git a/resources/views/names/show.blade.php b/resources/views/names/show.blade.php index 565d224..9ec0da5 100644 --- a/resources/views/names/show.blade.php +++ b/resources/views/names/show.blade.php @@ -10,20 +10,20 @@ }, "author": { "@type": "Organization", - "name": "choisisunprenom.com" + "name": "touslesprenoms.org" }, "publisher": { "@type": "Organization", - "name": "choisisunprenom.com", + "name": "touslesprenoms.org", "logo": { "@type": "ImageObject", - "url": "{{ $jsonLdSchema['image'] }}}" + "url": "{{ $jsonLdSchema['image'] }}" } }, "headline": "{{ $jsonLdSchema['headline'] }}", "image": {{ $jsonLdSchema['image'] }}, - "datePublished": "{{ $jsonLdSchema['date'] }}", - "dateModified": "{{ $jsonLdSchema['date'] }}", + "datePublished": "{{ $jsonLdSchema['created_at'] }}", + "dateModified": "{{ $jsonLdSchema['updated_at'] }}", } diff --git a/tests/Unit/ViewModels/Names/NameViewModelTest.php b/tests/Unit/ViewModels/Names/NameViewModelTest.php index e3d24a5..d58c35a 100644 --- a/tests/Unit/ViewModels/Names/NameViewModelTest.php +++ b/tests/Unit/ViewModels/Names/NameViewModelTest.php @@ -199,7 +199,8 @@ public function it_gets_the_data_to_feed_the_json_schema_ld_file(): void [ 'headline' => 'Tout savoir sur le prénom Héloïse', 'image' => env('APP_URL') . '/img/facebook.png', - 'date' => '2018-01-01', + 'created_at' => '2018-01-01', + 'updated_at' => '2018-01-01', 'url' => env('APP_URL') . '/prenoms/' . $name->id . '/heloise', ], $array