Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undo and redo modifier on embedded create/destroy #223

Open
dblock opened this issue Jun 19, 2018 · 0 comments
Open

Fix undo and redo modifier on embedded create/destroy #223

dblock opened this issue Jun 19, 2018 · 0 comments
Labels
bug

Comments

@dblock
Copy link
Collaborator

dblock commented Jun 19, 2018

Doing undo! or redo! on embedded objects on create/destroy doesn't correctly pass on the modifier.

See TODO in tracker#create_on_parent. Go through specs and remove any modifier_field_optional: true unless explicitly tested.

Via #221
@dblock dblock added the bug label Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dblock