feat(compass-collection): Submit collection validation rules to LLM - CLOUDP-347304#7478
Merged
feat(compass-collection): Submit collection validation rules to LLM - CLOUDP-347304#7478
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the mock data schema generation feature by including MongoDB collection validation rules in LLM requests. This allows the AI to generate more accurate faker.js mappings that respect collection constraints (e.g., email patterns, numeric ranges).
Key changes:
- Added
validationRulesparameter to LLM request payload - Added comprehensive test coverage for validation rules handling (provided, null, and undefined cases)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/compass-generative-ai/src/atlas-ai-service.ts | Added validationRules field to the request body sent to the LLM service |
| packages/compass-generative-ai/src/atlas-ai-service.spec.ts | Added test coverage for validation rules inclusion in requests, including edge cases for null and undefined values |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
johnjackweir
approved these changes
Oct 20, 2025
kpamaran
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include MongoDB collection validation rules in LLM requests to improve faker.js schema generation quality and accuracy.
Checklist
Motivation and Context
Types of changes