chore(configs): alias prettier and eslint bins through the local config packages (#6822)

* chore(configs): re-export eslint and prettier clis through config packages

* chore(configs): remove eslint and prettier from package dependencies

* chore(prettier-config): fix prettier bin path; ensure all scripts are calling the alias

* chore(prettier-config): remove configs and ignore files from workspaces

* fix(editor): editor actually depends on prettier

* chore(scripts): cleanup create-workspaces script

Author: gribnoysup

.husky/pre-commit

@@ -4,4 +4,8 @@
 # listings staged files only
 fileList=$(git diff --diff-filter=AM --cached --name-only)
 
-npm run precommit $fileList
+if [ -n "$fileList" ]; then
+  echo "Prettifying staged files..."
+  npx prettier-compass --write --ignore-unknown $fileList
+  git add $fileList
+fi

configs/eslint-config-compass/.prettierrc.json renamed to .prettierrc.json

@@ -0,0 +1,3 @@
+#!/usr/bin/env node
+'use strict';
+require('eslint/bin/eslint.js');

THIRD-PARTY-NOTICES.md

@@ -4,35 +4,35 @@
   "description": "Shared Compass eslint configuration",
   "license": "SSPL",
   "main": "index.js",
+  "bin": {
+    "eslint-compass": "./bin/eslint.js"
+  },
   "files": [
     "index.js",
+    "bin",
     "package.json",
     "README.md"
   ],
-  "peerDependencies": {
-    "eslint": "^7.25.0"
-  },
   "dependencies": {
     "@babel/core": "^7.21.4",
     "@babel/eslint-parser": "^7.14.3",
     "@mongodb-js/eslint-config-devtools": "^0.9.9",
     "@mongodb-js/eslint-plugin-compass": "^1.2.6",
     "@typescript-eslint/eslint-plugin": "^5.59.0",
     "@typescript-eslint/parser": "^5.59.0",
+    "eslint": "^7.25.0",
     "eslint-config-prettier": "^8.3.0",
     "eslint-plugin-filename-rules": "^1.2.0",
     "eslint-plugin-jsx-a11y": "^6.4.1",
     "eslint-plugin-mocha": "^8.0.0",
     "eslint-plugin-react": "^7.24.0",
     "eslint-plugin-react-hooks": "^4.2.0"
   },
-  "devDependencies": {
-    "prettier": "^2.7.1"
-  },
   "scripts": {
+    "prettier": "prettier-compass",
     "check": "npm run lint",
-    "lint": "prettier --check .",
-    "reformat": "prettier --write ."
+    "lint": "npm run prettier -- --check .",
+    "reformat": "npm run prettier -- --write ."
   },
   "repository": {
     "type": "git",

configs/eslint-config-compass/bin/eslint.js

@@ -24,8 +24,8 @@
   "license": "SSPL",
   "main": "index.js",
   "scripts": {
-    "eslint": "eslint",
-    "prettier": "prettier",
+    "eslint": "eslint-compass",
+    "prettier": "prettier-compass",
     "lint": "npm run eslint . && npm run prettier -- --check .",
     "depcheck": "depcheck",
     "check": "npm run lint && npm run depcheck",
@@ -42,7 +42,6 @@
     "depcheck": "^1.4.1",
     "eslint": "^7.25.0",
     "mocha": "^10.2.0",
-    "nyc": "^15.1.0",
-    "prettier": "^2.7.1"
+    "nyc": "^15.1.0"
   }
 }

configs/eslint-config-compass/package.json

@@ -5,11 +5,10 @@
   "license": "SSPL",
   "main": "index.js",
   "devDependencies": {
-    "@mongodb-js/prettier-config-compass": "^1.2.6",
-    "prettier": "^2.7.1"
+    "@mongodb-js/prettier-config-compass": "^1.2.6"
   },
   "scripts": {
-    "prettier": "prettier",
+    "prettier": "prettier-compass",
     "lint": "npm run prettier --  --check .",
     "check": "npm run lint",
     "check-ci": "npm run lint",

configs/eslint-plugin-compass/.prettierignore

@@ -1,3 +1,4 @@
 .nyc_output
+.nyc-output
 dist
 coverage

configs/eslint-plugin-compass/.prettierrc.json

@@ -0,0 +1,15 @@
+#!/usr/bin/env node
+'use strict';
+const path = require('path');
+const fs = require('fs');
+if (process.argv.some((arg) => /^--(no-)?config/.test(arg))) {
+  throw new Error('--config option is not allowed');
+}
+process.argv.push('--config', path.resolve(__dirname, '..', 'index.js'));
+if (!fs.existsSync(path.resolve(process.cwd(), '.prettierignore'))) {
+  process.argv.push(
+    '--ignore-path',
+    path.resolve(__dirname, '..', '.prettierignore-default')
+  );
+}
+require('prettier/bin-prettier.js');

configs/eslint-plugin-compass/package.json

@@ -4,17 +4,20 @@
   "description": "Shared Compass prettier configuration",
   "license": "SSPL",
   "main": "index.js",
+  "bin": {
+    "prettier-compass": "./bin/prettier.js"
+  },
   "peerDependencies": {
     "prettier": "^2.7.1"
   },
   "devDependencies": {
-    "prettier": "^2.7.1",
     "@mongodb-js/prettier-config-devtools": "^1.0.1"
   },
   "scripts": {
+    "prettier": "prettier-compass",
     "check": "npm run lint",
-    "lint": "prettier --check .",
-    "reformat": "prettier --write ."
+    "lint": "npm run prettier -- --check .",
+    "reformat": "npm run prettier -- --write ."
   },
   "repository": {
     "type": "git",

configs/mocha-config-compass/.prettierrc.json

@@ -32,8 +32,8 @@
   "scripts": {
     "compile": "tsc -p tsconfig.json",
     "typecheck": "tsc -p tsconfig-lint.json --noEmit",
-    "eslint": "eslint",
-    "prettier": "prettier",
+    "eslint": "eslint-compass",
+    "prettier": "prettier-compass",
     "lint": "npm run eslint . && npm run prettier -- --check .",
     "depcheck": "depcheck",
     "check": "npm run typecheck && npm run lint && npm run depcheck",
@@ -54,10 +54,8 @@
     "@types/sinon-chai": "^3.2.5",
     "chai": "^4.3.6",
     "depcheck": "^1.4.1",
-    "eslint": "^7.25.0",
     "mocha": "^10.2.0",
     "nyc": "^15.1.0",
-    "prettier": "^2.7.1",
     "typescript": "^5.0.4"
   },
   "dependencies": {

configs/mocha-config-compass/package.json

@@ -11,8 +11,7 @@
     "typescript": "^5.0.4"
   },
   "devDependencies": {
-    "@mongodb-js/prettier-config-compass": "^1.2.6",
-    "prettier": "^2.7.1"
+    "@mongodb-js/prettier-config-compass": "^1.2.6"
   },
   "dependencies": {
     "@mongodb-js/tsconfig-devtools": "^1.0.0"

packages/compass-crud/.prettierignore renamed to configs/prettier-config-compass/.prettierignore-default

@@ -36,8 +36,8 @@
     "prepublishOnly": "npm run compile && compass-scripts check-exports-exist",
     "compile": "tsc -p tsconfig.json",
     "postcompile": "gen-esm-wrapper . ./dist/.esm-wrapper.mjs",
-    "eslint": "eslint",
-    "prettier": "prettier",
+    "eslint": "eslint-compass",
+    "prettier": "prettier-compass",
     "lint": "npm run eslint . && npm run prettier -- --check .",
     "depcheck": "depcheck",
     "check": "npm run lint && npm run depcheck",
@@ -52,8 +52,6 @@
     "@types/html-webpack-plugin": "^3.2.9",
     "@types/webpack-bundle-analyzer": "^4.7.0",
     "depcheck": "^1.4.1",
-    "eslint": "^7.25.0",
-    "prettier": "^2.7.1",
     "typescript": "^5.0.4"
   },
   "dependencies": {