-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer a "Teller" object #629
Comments
I would suggest codereview.stackexchange.com as an alternative place to post the code. Just formally, i.e. without addressing whether it should be part of this library or not, here are a few notes:
|
Thanks @UlrichEckhardt, though I should have specified I was rather looking for feedback from @sagikazarmark, @frederikbosch, or one of the other more senior folks on this project, as to whether this kind of offering was appropriate for the purposes of MoneyPHP in the first place. (If it is, great; if not, that's OK too.) |
@pmjones thanks for reaching out. I'm definitely not against hosting code that helps the community and does not massively increase the size of this library. I think the above code fits both of those criteria. @frederikbosch any objections? |
No objections. Looks good! It should be tested though. I am planning some major work for this library in the near future. I will include |
@sagikazarmark @frederikbosch You can see a PR with docs and tests at #630 -- let me know if you need anything, and thanks for considering it. |
This would definitely help us migrate and refactor our product over to use moneyphp/money Thanks! |
Hi -- in my legacy refactoring work, I have found it useful to introduce a Teller (as in "bank teller") object to ease the transition from float math to Money objects. I wanted to give this project the chance to review, then accept or reject it, before I consider releasing it as a library of its own. The Teller class is pasted below; if you find it suitable for inclusion, let me know and I'll send a PR proper with docs and tests for it. Thanks, hope you are all doing well!
The text was updated successfully, but these errors were encountered: