-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculator Question #153
Comments
@browner12 The |
Reasoning and design decisions to be found with the PR at #115. |
@browner12 I am not completely sure I remember what exactly your design was. But if I am correct, your "Calculators" were "outside" of the Money API. While our calculators are encapsulated into the Money object API. It is an internal detail which allow us to use various numeric value handling. Hope that answers your question. |
thanks @frederikbosch yup, @sagikazarmark, that was it. mine was external rather than being a dependency of my |
About a year ago I submitted a proposal to the PHP League of my implementation of a money package. I got good feedback from both @mathiasverraes and @sagikazarmark. I had proposed separating responsibilities out into both a
Money
class and anAccountant
class. You both argued that money should inherently know how to do math on itself, and that anAccountant
was unnecessary. Now as I look at yournextrelease
branch of your money package I see that you guys have createdCalculator
s, which I believe is exactly what I was proposing. I'd love to talk with you guys a bit about what made you change your minds on this issue.Thanks!
The text was updated successfully, but these errors were encountered: