Is this project abandoned?

[francoispienaar]

Hi there,

I wanted to know if this repo/package is considered abandoned?

I am interested in using/extending/maintaining a fork for the Symfony community.

[sagikazarmark]

Historically, this bundle was always a community effort, not something that the core maintainers actively worked on. We simply tried to provide a home for it, because we saw value in endorsing an "official" solution.

I'd say that hasn't changed, even if the project seems dormant at the moment. If someone showed continued interest in the project and expressed interest in stepping up as a maintainer, I'd be more than happy to give access to the repository.

We have no formal onboarding process, but sending a couple high quality PRs, opening feature requests/bug reports would demonstrate said interest.

What do you think?

[francoispienaar]

Sounds good :)

Do you have "official"/preferred contribution guidelines and code standards to follow? And things like official PHP release tracking? I see this repo still supports PHP 7.2 even though it's EOL. I also want to know if this is the correct place to add Doctrine support/extensions, or if you would rather that be added in a separate Doctrine bundle?

Thanks!

[sagikazarmark]

I have to admit, I'm not up-to-date with the latest-greatest, fancy PHP "standard" stuff.

In general:

• Keep changesets small
• Cover changes with tests

Specific to PHP: I guess it's a safe bet to follow whatever PHP suggests (support the last two versions?). On the other hand, don't break compatibility just to upgrade a version number.

I've spent some time building CI for moneyphp and Guzzle in the last couple years. That should include static analysis checks. As a rule of thumb we should follow those, but I'm open to suggestions.

As for doctrine: I don't know. What do people do these days? It sounds like a good idea to provide a doctrine extension as a separate library and just depend on it in the symfony bundle. That way people not using symfony can still use moneyphp with doctrine. But I can also imagine starting with this bundle and splitting doctrine related code to a separate lib later.

One comment about doctrine: there have been some conversations (maybe even heated arguments) about how a doctrine extension for moneyphp should look like. I don't remember the details, but I think you can still find those discussions on the issue tracker (of moneyphp). Might be worth checking out first.

Thanks for taking the time.

[mbabker]

Not that I'm trying to self-promote or step on anyone's toes here, but I put https://github.com/BabDev/MoneyBundle out into the wild to share some of the tools I was consistently writing and using for work projects. By all means, feel free to borrow inspiration from it.

[sagikazarmark]

Nice, thanks for sharing @mbabker ! Maybe we should add an integrations section somewhere under the docs/main project readme and add projects like this there.