Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added MsDefender integration #171

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

mati007thm
Copy link
Contributor

@mati007thm mati007thm commented Dec 4, 2024

fixes #163

@mati007thm
Copy link
Contributor Author

@chris-rock I encountered 2 problems here:

  1. msdefender is not recognised as a word by the spellchecker. We would need to include it or switch to a different name like microsoft_defender
  2. I do not receive the state in the .tfstate file when applying the configuration. Could this be due to the fact that the integration is still a feature flag https://console.mondoo.com/flags ? Because the integration is crated and I did nothing different than what I did for other integrations
image

And finally I have a question regarding the Azure application that needs to be created. Does it need the same configuration/permission as the Azure integration? For now I simply used the Azure integration example and only switched the the actual integration from mondoo_integration_azure to mondoo_integration_msdefender.

@afiune
Copy link
Contributor

afiune commented Dec 5, 2024

Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check the issue with the feature flag, in the meantime, lets work on these comments plus adding some tests similar to https://github.com/mondoohq/terraform-provider-mondoo/blob/main/internal/provider/integration_shodan_resource_test.go

internal/provider/integration_msdefender_resource.go Outdated Show resolved Hide resolved
internal/provider/integration_msdefender_resource.go Outdated Show resolved Hide resolved
@mati007thm
Copy link
Contributor Author

@afiune I made the requested changes

@chris-rock
Copy link
Member

@mati007thm Can you please rebase the PR?

Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will enable the feature flag for our test environment used by CI. Code looks good to me.

mati007thm and others added 4 commits December 16, 2024 08:27
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
@mati007thm mati007thm force-pushed the msdefender_integration branch from 0edb6c9 to eb8a052 Compare December 16, 2024 07:35
@mati007thm
Copy link
Contributor Author

@chris-rock, @afiune rebased the branch

@chris-rock chris-rock merged commit f14b46c into mondoohq:main Dec 16, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MS Defender Integration setup
3 participants