-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added MsDefender integration #171
Conversation
@chris-rock I encountered 2 problems here:
And finally I have a question regarding the Azure application that needs to be created. Does it need the same configuration/permission as the Azure integration? For now I simply used the Azure integration example and only switched the the actual integration from |
@mati007thm you can fix the spell problems updating this https://github.com/mondoohq/terraform-provider-mondoo/tree/main/.github/actions/spelling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check the issue with the feature flag, in the meantime, lets work on these comments plus adding some tests similar to https://github.com/mondoohq/terraform-provider-mondoo/blob/main/internal/provider/integration_shodan_resource_test.go
@afiune I made the requested changes |
@mati007thm Can you please rebase the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
Signed-off-by: Matthias Theuermann <[email protected]>
0edb6c9
to
eb8a052
Compare
@chris-rock, @afiune rebased the branch |
fixes #163