Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added zendesk integration #170

Merged
merged 6 commits into from
Dec 13, 2024
Merged

feat: added zendesk integration #170

merged 6 commits into from
Dec 13, 2024

Conversation

mati007thm
Copy link
Contributor

@mati007thm mati007thm commented Dec 4, 2024 •
edited by chris-rock
Loading

fixes #161

@mati007thm
feat: added zendesk integration
3c90500 
Signed-off-by: Matthias Theuermann <[email protected]>
@mati007thm mati007thm mentioned this pull request Dec 4, 2024
Closed
afiune
afiune requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test similar to https://github.com/mondoohq/terraform-provider-mondoo/blob/main/internal/provider/integration_shodan_resource_test.go

internal/provider/integration_zendesk_resource.go Outdated Show resolved Hide resolved
internal/provider/integration_zendesk_resource.go Outdated Show resolved Hide resolved
internal/provider/integration_zendesk_resource.go Show resolved Hide resolved
@mati007thm
Copy link
Contributor Author

@afiune I made the requested changes

afiune
afiune approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afiune
Copy link
Contributor

afiune commented Dec 10, 2024

@mati007thm same with this one, rebase so we can merge 💯

@afiune
Copy link
Contributor

afiune commented Dec 10, 2024

Also look at #180, you might need to resolve something in the acceptance tests.

@mati007thm
Copy link
Contributor Author

@afiune I changed the acceptance tests. Hope this works now!

@afiune
Copy link
Contributor

afiune commented Dec 13, 2024

@mati007thm this is also ready, need a rebase.

@mati007thm
Copy link
Contributor Author

@afiune I rebased it

@chris-rock chris-rock merged commit ebbac97 into mondoohq:main Dec 13, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chris-rock chris-rock chris-rock left review comments

@afiune afiune afiune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Zendesk integration setup
3 participants
@mati007thm @afiune @chris-rock