From 7b3fd5544b46ffc2803606714fe92e11ebd428e5 Mon Sep 17 00:00:00 2001 From: Matthias Theuermann Date: Mon, 16 Dec 2024 11:20:11 +0100 Subject: [PATCH] fix: tests and integration state Signed-off-by: Matthias Theuermann --- internal/provider/integration_msdefender_resource.go | 1 - internal/provider/integration_msdefender_resource_test.go | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/internal/provider/integration_msdefender_resource.go b/internal/provider/integration_msdefender_resource.go index f64bbad..ee839b9 100644 --- a/internal/provider/integration_msdefender_resource.go +++ b/internal/provider/integration_msdefender_resource.go @@ -205,7 +205,6 @@ func (r *integrationMsDefenderResource) Create(ctx context.Context, req resource AddWarning("Client Error", fmt.Sprintf("Unable to trigger integration, got error: %s", err), ) - return } // Save space mrn into the Terraform state. diff --git a/internal/provider/integration_msdefender_resource_test.go b/internal/provider/integration_msdefender_resource_test.go index e9a1b24..b509efc 100644 --- a/internal/provider/integration_msdefender_resource_test.go +++ b/internal/provider/integration_msdefender_resource_test.go @@ -23,7 +23,7 @@ func TestAccMsDefenderIntegrationResource(t *testing.T) { resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "space_id", accSpace.ID()), resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "tenant_id", "ffffffff-ffff-ffff-ffff-ffffffffffff"), resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "client_id", "ffffffff-ffff-ffff-ffff-ffffffffffff"), - resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "subscription_allow_list", `["ffffffff-ffff-ffff-ffff-ffffffffffff", "ffffffff-ffff-ffff-ffff-ffffffffffff"]`), + resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "subscription_allow_list.0", "ffffffff-ffff-ffff-ffff-ffffffffffff"), ), }, { @@ -31,7 +31,7 @@ func TestAccMsDefenderIntegrationResource(t *testing.T) { Check: resource.ComposeAggregateTestCheckFunc( resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "name", "two"), resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "space_id", accSpace.ID()), - resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "subscription_deny_list", `["ffffffff-ffff-ffff-ffff-ffffffffffff", "ffffffff-ffff-ffff-ffff-ffffffffffff"]`), + resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "subscription_deny_list.0", "ffffffff-ffff-ffff-ffff-ffffffffffff"), resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "credentials.pem_file", "abcd1234567890"), ), }, @@ -43,7 +43,7 @@ func TestAccMsDefenderIntegrationResource(t *testing.T) { resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "space_id", accSpace.ID()), resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "tenant_id", "ffffffff-ffff-ffff-ffff-ffffffffff"), resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "client_id", "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"), - resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "subscription_allow_list", `["aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa", "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"]`), + resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "subscription_allow_list.0", "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"), ), }, { @@ -51,7 +51,7 @@ func TestAccMsDefenderIntegrationResource(t *testing.T) { Check: resource.ComposeAggregateTestCheckFunc( resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "name", "four"), resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "space_id", accSpace.ID()), - resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "subscription_deny_list", `["aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa", "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"]`), + resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "subscription_deny_list.0", "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"), resource.TestCheckResourceAttr("mondoo_integration_msdefender.msdefender_integration", "credentials.pem_file", "abcd1234567890"), ), },