Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise synonyms for 'developmental and epileptic encephalopathy, 31A' #8605

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

nicolevasilevsky
Copy link
Member

close #8019

Copy link
Collaborator

@katiermullen katiermullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolevasilevsky I left some comments for you. Some of them are for my own knowledge. Thank you so much!

@@ -558450,6 +558452,7 @@ name: developmental and epileptic encephalopathy, 31B
def: "Any developmental and epileptic encephalopathy in which the cause of the disease is a homozygous mutation in the DNM1 gene." [https://orcid.org/0000-0002-0587-4693, OMIM:620352]
subset: gard_rare {source="MONDO:GARD"}
subset: rare
synonym: "developmental and epileptic encephalopathy 31B, autosomal recessive" EXACT [OMIM:620352]
synonym: "developmental and epileptic encephalopathy 31B, autosomal recessive" EXACT [https://orcid.org/0000-0001-9310-0163]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps combine these above two lines?

Also this syn was not requested in the ticket, but I did find that OMIM lists the syn DEE31B.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolevasilevsky what do you think about adding the exact syn DEE31B to this term for completeness? Source is OMIM:620352.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea, will do

src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
@nicolevasilevsky
Copy link
Member Author

this is ready for re-review @katiermullen

Copy link
Collaborator

@katiermullen katiermullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolevasilevsky I approve this PR. I just wonder if the exact syn DEE31B should be added to term MONDO:0957248 before merging? Thank you for all of your work on these issues!

@@ -558450,6 +558452,7 @@ name: developmental and epileptic encephalopathy, 31B
def: "Any developmental and epileptic encephalopathy in which the cause of the disease is a homozygous mutation in the DNM1 gene." [https://orcid.org/0000-0002-0587-4693, OMIM:620352]
subset: gard_rare {source="MONDO:GARD"}
subset: rare
synonym: "developmental and epileptic encephalopathy 31B, autosomal recessive" EXACT [OMIM:620352]
synonym: "developmental and epileptic encephalopathy 31B, autosomal recessive" EXACT [https://orcid.org/0000-0001-9310-0163]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolevasilevsky what do you think about adding the exact syn DEE31B to this term for completeness? Source is OMIM:620352.

@nicolevasilevsky nicolevasilevsky merged commit 07d7e22 into master Jan 23, 2025
1 check passed
@nicolevasilevsky nicolevasilevsky deleted the issue-8019 branch January 23, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developmental and epileptic encephalopathy 31A, autosomal dominant
2 participants