Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONDO:0000432 Self-Loop JSON Loading #7935

Closed
iimpulse opened this issue Jul 10, 2024 · 4 comments · Fixed by #7960 or #7961
Closed

MONDO:0000432 Self-Loop JSON Loading #7935

iimpulse opened this issue Jul 10, 2024 · 4 comments · Fixed by #7960 or #7961
Assignees
Labels
bug tech issue requiring work from the technical team

Comments

@iimpulse
Copy link
Member

iimpulse commented Jul 10, 2024

MONDO:0000432

Bug/Typo/Error description
When loading the simple base graph with our internal ontology load phenol we fail to parse the graph to due a self referencing loop.

Self-loop edge: Relationship [source=MONDO:0000432, target=MONDO:0000432, id=361, relationshipType=RelationshipType{id='http://purl.obolibrary.org/obo/RO_0004029', label='disease has feature'}]',

https://orcid.org/0000-0002-2157-3591

@iimpulse iimpulse added the bug label Jul 10, 2024
@matentzn
Copy link
Member

Which file are you using?

@matentzn
Copy link
Member

matentzn commented Jul 10, 2024

This is the cycle:

[Term]
id: MONDO:0000432
....
relationship: disease_has_feature MONDO:0000432 {source="MONDO:Wikidata"} ! lymphoplasmacytic lymphoma

MONDO:0000432 is a phenotypic feature of itself.

@matentzn
Copy link
Member

Here is the qc check that need to be added:

PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
prefix IAO: <http://purl.obolibrary.org/obo/IAO_>
prefix MONDO: <http://purl.obolibrary.org/obo/MONDO_>
prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>
prefix oio: <http://www.geneontology.org/formats/oboInOwl#>
prefix def: <http://purl.obolibrary.org/obo/IAO_0000115>
prefix owl: <http://www.w3.org/2002/07/owl#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX RO: <http://purl.obolibrary.org/obo/RO_>


SELECT ?entity ?property ?value 

WHERE
{
  VALUES ?property { RO:0004003 RO:0004029 }
  ?entity rdfs:subClassOf [
        owl:onProperty ?property ;
        owl:someValuesFrom ?entity
      ] .
  BIND ("Self cycle detected" as ?value)
} 

@twhetzel can you take this on? This is a real bug and should be fixed before the release I think!

@twhetzel
Copy link
Collaborator

Sure, I can do this.

@twhetzel twhetzel self-assigned this Jul 10, 2024
@twhetzel twhetzel added the tech issue requiring work from the technical team label Jul 10, 2024
This was referenced Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tech issue requiring work from the technical team
Projects
None yet
3 participants