Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New term Dyneinopathy #7894

Merged
merged 4 commits into from
Jul 12, 2024
Merged

New term Dyneinopathy #7894

merged 4 commits into from
Jul 12, 2024

Conversation

yshwetar
Copy link
Collaborator

@yshwetar yshwetar commented Jul 1, 2024

Closes #7652

Includes the following

  • Definition
  • 3 PMIDs for definition
  • 2 Parent classes
  • 2 Children classes

Closes #7652

Includes the following
- Definition
- 3 PMIDs for definition
- 2 Parent classes
- 2 Children classes
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments.

In addition to making the changes in the comments, you should also address the requester's ask related to " 'Spinal muscular atrophy, lower extremity-predominant 1, AD'"
For what I can tell from my quick review, we already have a term, MONDO:0008026 ('autosomal dominant childhood-onset proximal spinal muscular atrophy without contractures'), which has and exact x-ref to OMIM:158600.
If it is what the term that the requester asked, it is already in Mondo** (note that we might have created this term after the request was created). In this case you should add this term as a child of "dyneinopathy". Remember to add sources! :-)

**in doubt, you can ask the requester to confirm that the MONDO:0008026 represents the term she requested.

src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
@sabrinatoro sabrinatoro removed their assignment Jul 4, 2024
- Removed first letter capitalization
- Added ORCID, Clingen, OMIM, and PMID as respective annotations

Did not yet address the addition of spinal muscular atrophy per the request of collaborator.
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yshwetar
One detail: I think you can add a SubClassOf annotation :
'has material basis in germline mutation in' some DYNC1H1
Remember to add a source for this SC.

Also, check/confirm that it is the ID that you want to use for this term.

Other than that, it looks great! Thank you!

@sabrinatoro sabrinatoro removed their assignment Jul 9, 2024
Previous MONDO ID was 1040000, which has been used in other commits. Updated this ID to 1040031.

Also added the SubClassOf annotation: 'has material basis in germline mutation in' some DYNC1H1, along with sources for this.
@nicolevasilevsky
Copy link
Member

@yshwetar we should add the term tracker item to the new terms:
#7652

See: https://mondo.readthedocs.io/en/latest/editors-guide/f-entities/#term-tracker-item

Let me know if you need help with this (I did show this is a video in the ICBO tutorial yesterday)

@nicolevasilevsky
Copy link
Member

@yshwetar please assign this back to me when it is ready for re-review, thanks!

Minor updates to the definition of dyneinopathy. Removed ncbi search URL and placed PMID of genereviews. Also created a term tracker item.
Copy link
Member

@nicolevasilevsky nicolevasilevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@nicolevasilevsky nicolevasilevsky merged commit 62f91c4 into master Jul 12, 2024
1 check passed
@nicolevasilevsky nicolevasilevsky deleted the issue-7652 branch July 12, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for new term [Dyneinopathy]
3 participants