Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: fixes for media gallery #1251

Open
6 of 23 tasks
matthewrfennell opened this issue Sep 25, 2024 · 1 comment
Open
6 of 23 tasks

[Feature]: fixes for media gallery #1251

matthewrfennell opened this issue Sep 25, 2024 · 1 comment

Comments

@matthewrfennell
Copy link
Member

matthewrfennell commented Sep 25, 2024

(below copied from #1221):

  • Wrong coding style in the objc part

  • Don't use NSLog but proper DDLogXXX

  • If I tap the X icon in media viewer I don't get back to the gallery, but back to the contact details

  • Share button of MediaViewer isn't displayed for video files, only for images

  • The thumbnail in the gallery does not indicate that this is a video at all

  • The thumbnails in the gallery are squished to a square aspect ratio

  • The native video UI VERY BADLY interferes with the MediaViewer UI (pinch, zoom, show close and share buttons etc.)

  • Opening an image from the chat view doesn't allow the user to swipe left/right in the mediaviewer like when opening a media file from gallery.

  • Images opened via media gallery should show in a fullscreen view, like when tapping onto an image in the chat

  • Don't use an extension for UIImage to calculate a thumbnail (currently defined at the end of SwiftHelpers.swift)
    ntial enhancements:

  • Show the most recent media first:
    Currently, the oldest media is shown at the top, and the newest at the bottom
    two possible ways to do it:

    • flip the sorting so the most recent is shown at the top
    • load the MediaGallery view at the very bottom, and let users scroll up if they want to see older items
      (this is what the iOS Photos app does. But I'm not sure which method is preferred)
  • Add the possibility to scroll down from the MediaViewer to close it. (This is already possible if you're viewing images from the Media Gallery, but not if you're viewing an image in full-screen from the chat directly)

  • Currently, in the ContactDetails, there are two similar entries show shared Media and Files and View Media Gallery
    The former opens the file manager, in a directory that contains file uploads for that chat (all files, not just media).
    Users are tempted to press the show shared Media and Files because it's placed before the other option, and because it has easier wording.
    Make the View Media Galleryoption more prominent (for example by placing in on top of the other option and improving its wording)

  • When a chat doesn't have any shared media yet, the show shared Media and Files button is hidden, but the View Media Gallery button is shown.
    Consider hiding it as well.

Feature requests:

  • When using macOS, It would be nice to be able to download the file we're viewing. Now we can only "Save to Photos".

  • The iOS Photos app shows the date of when the photos were created / downloaded, overlayed on top of the media items, and it changes as we scroll up and down. It would be nice if this could be replicated. (showing only the month and year, instead of the full date, may make it easier)

  • Add support for PDF documents (including showing a preview of the first page as a thumbnail, with a way to distinguish it from thumbnails of photos and videos, like a "pdf" overlayed on top of it)

  • It is possible to scroll "past" the edge of an image when zoomed in

  • Hide status bar and slide bar when controls are not visible

  • Make media gallery look more like Apple photos app (less spacing, no rounded corners?)

  • Prevent jumping around while images are loading, and fade smoothly between progress and thumbnail views

  • When opening a video from the chat, it should open directly in the swipe view (like images now do)

  • Create a class to replace our usage of [String: Any]

@tmolitor-stud-tu
Copy link
Member

@matthewrfennell could you move the checklist of our media viewer PR into this issue, too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants