Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First song can't be from querried packs. #55

Open
Ondrej-Douda opened this issue Nov 4, 2021 · 5 comments
Open

First song can't be from querried packs. #55

Ondrej-Douda opened this issue Nov 4, 2021 · 5 comments

Comments

@Ondrej-Douda
Copy link

When external respack is loaded using URL querry, first song can't be selected from this respack...
Example: https://0x40.mon.im/montegral.html?autoSong=off&packs=mon.zip&skipPreloader=off&song=lobster_loop

This will load selected respack, but use first song from default respack...

@mon
Copy link
Owner

mon commented Nov 5, 2021

Ah - the search for songs is based on the song name only, so if you provide song=LÅT it works fine.

There are some solutions here, such as just using the song name, or extending the search to also use the artist name and the filename, what are your thoughts?

@Ondrej-Douda
Copy link
Author

Oh, so it searches by title, not song name, haven't thought about that...
Using title is fine for me, but might be extended to use also filename (mentioned usecase)...

Some additional thoughts (might exist, but missed them): (Would be nice to be able to)

  • reference remote/external respacks using URL.
  • filter/deselect/forbid some respacks' resources (images/songs).
  • hide UI.
  • remove/delete already imported respacks.
  • reconstruct/generate URL with current settings (setup using UI, share by copy/paste).
  • add/append additional packsURL.

And I want to thank you for maintaining this wonderful tool/app/page/platform...

@mon
Copy link
Owner

mon commented Nov 5, 2021

Here's my recommendation:
If you can host external respacks, you can host your own hues! This solves

  • reference remote/external respacks using URL.
  • add/append additional packsURL
  • filter/deselect/forbid some respacks' resources (images/songs)
  • remove/delete already imported respacks.
    • Just delete them
  • hide UI
    • make a CSS rule: .hues-ui { display: none }

The one I can't easily solve at the moment:
reconstruct/generate URL with current settings (setup using UI, share by copy/paste).

I like the idea, but it might take some time to implement as I am time-poor.

@Ondrej-Douda
Copy link
Author

These thought were mostly about ability to tailor already hosted hues...
Referencing external respacks would be for ability to load others work from different hues/sites...
Then you could merge and choose from all the resource available on internet...
Most of the "recomendations" are targeted for querring...

If you don't mind I'll fiddle with your code and possibly make some improving PRs...

@mon
Copy link
Owner

mon commented Nov 5, 2021

Seems reasonable enough - that's why the code is open-source, after all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants