diff --git a/CHANGELOG.md b/CHANGELOG.md index 544ecac..31b66d1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -56,6 +56,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/). 1. Made the tree view font size configurable with the [`tree_view_font_size` setting](/docs/README.md#styling-of-forms). Fixes [issue 66](https://github.com/molsonkiko/JsonToolsNppPlugin/issues/66). 2. Added dark mode tree view icons (addresses [this GH issue comment](https://github.com/molsonkiko/JsonToolsNppPlugin/issues/66#issuecomment-2169216078)). +### Changed + +1. Removed the `max_threads_parsing` setting for the [JSON from files and APIs form](/docs/README.md#get-json-from-files-and-apis), because nobody upvoted the first post in [GH issue 67](https://github.com/molsonkiko/JsonToolsNppPlugin/issues/67). + ### Fixed 1. Avoid unnecessarily refreshing the styles of all forms when settings other than `use_npp_styling` or `tree_view_font_size` are changed. diff --git a/JsonToolsNppPlugin/Forms/GrepperForm.cs b/JsonToolsNppPlugin/Forms/GrepperForm.cs index 3129993..8eb4b15 100644 --- a/JsonToolsNppPlugin/Forms/GrepperForm.cs +++ b/JsonToolsNppPlugin/Forms/GrepperForm.cs @@ -13,6 +13,12 @@ namespace JSON_Tools.Forms { public partial class GrepperForm : Form { + /// + /// maximum number of threads to use when parsing JSON + /// (each thread parses a separate subset of the documents) + /// + public const int MAX_THREADS_PARSING = 4; + public TreeViewer tv; public JsonGrepper grepper; HashSet filesFound; @@ -26,7 +32,7 @@ public GrepperForm() NppFormHelper.RegisterFormIfModeless(this, false); FormStyle.ApplyStyle(this, Main.settings.use_npp_styling); grepper = new JsonGrepper(Main.JsonParserFromSettings(), - Main.settings.max_threads_parsing + MAX_THREADS_PARSING ); tv = null; filesFound = new HashSet(); diff --git a/JsonToolsNppPlugin/Main.cs b/JsonToolsNppPlugin/Main.cs index 230db27..e5b30d1 100644 --- a/JsonToolsNppPlugin/Main.cs +++ b/JsonToolsNppPlugin/Main.cs @@ -1157,7 +1157,6 @@ static void OpenSettings() if (grepperForm != null && !grepperForm.IsDisposed) { grepperForm.grepper.jsonParser = JsonParserFromSettings(); - grepperForm.grepper.maxThreadsParsing = settings.max_threads_parsing; } if (settings.tree_view_font_size != oldTreeViewFontSize || settings.use_npp_styling != oldUseNppStyling) RestyleEverything(); diff --git a/JsonToolsNppPlugin/Properties/AssemblyInfo.cs b/JsonToolsNppPlugin/Properties/AssemblyInfo.cs index efd8a72..2752478 100644 --- a/JsonToolsNppPlugin/Properties/AssemblyInfo.cs +++ b/JsonToolsNppPlugin/Properties/AssemblyInfo.cs @@ -28,5 +28,5 @@ // Build Number // Revision // -[assembly: AssemblyVersion("7.2.0.2")] -[assembly: AssemblyFileVersion("7.2.0.2")] +[assembly: AssemblyVersion("7.2.0.3")] +[assembly: AssemblyFileVersion("7.2.0.3")] diff --git a/JsonToolsNppPlugin/Utils/Settings.cs b/JsonToolsNppPlugin/Utils/Settings.cs index 9d04b07..6dded06 100644 --- a/JsonToolsNppPlugin/Utils/Settings.cs +++ b/JsonToolsNppPlugin/Utils/Settings.cs @@ -153,12 +153,6 @@ public class Settings : SettingsBase public bool auto_try_guess_csv_delim_newline { get; set; } #endregion - #region GREP_API_SETTINGS - [Description("How many threads to use for parsing JSON files obtained by JsonGrep and API requester"), - Category("Grep and API requests"), DefaultValue(4)] - public int max_threads_parsing { get; set; } - #endregion - #region STYLING [Description("Use the same colors as the editor window for the tree viewer and other JsonTools forms?"), Category("Styling"), DefaultValue(true)]