Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emx2-pyclient): delete_records needs check on data input #4333

Open
dtroelofsprins opened this issue Oct 10, 2024 · 0 comments
Open

fix(emx2-pyclient): delete_records needs check on data input #4333

dtroelofsprins opened this issue Oct 10, 2024 · 0 comments

Comments

@dtroelofsprins
Copy link
Contributor

dtroelofsprins commented Oct 10, 2024

Is your feature request related to a problem? Please describe.
The records to be deleted using delete_records can either be in a file or in a list or dataFrame.
Even in the documentation it says:The records that are to be deleted are specified in either a CSV file, or in a list of primary key values, or a pandas DataFrame representing the table on the schema
This list however should be a list of dictionaries (example in the documentation also shows this).

When just a single list with PK's is entered, it even seems as if data has been deleted as the response is: INFO: Molgenis EMX2 Pyclient: Deleted data from MYSCHEMA::MYTABLE where in fact nothing has happened.

It would be good to include a check that it's actual a list of dictionaries and also make this more clear in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant