Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalogue): menu on the left hand side of the cohort detail page doesn't always match the blocks on the right hand side #4320

Open
2 tasks
Tracked by #4147
EleanorHyde-UMCG opened this issue Oct 7, 2024 · 3 comments

Comments

@EleanorHyde-UMCG
Copy link
Contributor

EleanorHyde-UMCG commented Oct 7, 2024

ORIGINAL TEXT: Eleanor design: On cohort page, the ‘Partners’-section is missing. The ‘Available Data & Samples’-section is there, but it is missing from the sidebar. ’Networks’-section is called ‘Networks’ in sidebar, but ‘Part of Networks’ in the main content screen.
See: $testCatalogue/ssr-catalogue/testNetwork1/cohorts/testCohort2. (test 3 step 6b/test 5 step 11, 53/test 9 step 26)

EDIT: the 'Partners' issue has been solved by the reorganisation of lead organisation and contributors. The 'Networks'/'Part of networks' issue has been solved.

  • The menu on the left hand side (LHS), however, doesn't always match the blocks on the right hand side (RHS) on the cohort detail page. Here are some examples:

https://data-catalogue-acc.molgeniscloud.org/catalogue/ssr-catalogue/ATHLETE/cohorts/BIB#AvailableData "Available Data & Samples" is an option in the menu on the LHS but there is no block for it on the RHS.

https://data-catalogue-acc.molgeniscloud.org/testCatalogue/ssr-catalogue/testNetwork1/cohorts/testCohort2 DOES have Available Data & Samples on the RHS and the menu on the LHS shows it, too. This is correct.

  • fix test plans 3, 5, 9)
@EleanorHyde-UMCG EleanorHyde-UMCG changed the title Eleanor design: On cohort page, the ‘Partners’-section is missing. The ‘Available Data & Samples’-section is there, but it is missing from the sidebar. ’Networks’-section is called ‘Networks’ in sidebar, but ‘Part of Networks’ in the main content screen. See: $testCatalogue/ssr-catalogue/testNetwork1/cohorts/testCohort2. (test 3 step 6b/test 5 step 11, 53/test 9 step 26) fix(catalogue): menu on the left hand side of the cohort detail page doesn't always match the blocks on the right hand side Oct 7, 2024
@connoratrug
Copy link
Contributor

can no longer reproduce on latest

@EleanorHyde-UMCG
Copy link
Contributor Author

Has this gone to ACC yet? I can still reproduce it there.

@EleanorHyde-UMCG
Copy link
Contributor Author

eg DNBC in acc shows more headings on the LHS than there are on the RHS (available data and samples) https://data-catalogue-acc.molgeniscloud.org/catalogue/ssr-catalogue/all/cohorts/DNBC#AvailableData

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants