Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to /version path return apps version #44

Open
ConnorStroomberg opened this issue May 29, 2017 · 1 comment
Open

Request to /version path return apps version #44

ConnorStroomberg opened this issue May 29, 2017 · 1 comment

Comments

@ConnorStroomberg
Copy link
Contributor

A GET request to the molgenis api at '/api/v2/version' returns the apps version as ( 1.0.0 at the moment). This request used to return the molgenis-platform version ( 4.0.0. at at the moment).

For example at the time of writing a request to the genetics app at

https://molgenis43.gcc.rug.nl/api/v2/version

returns

{"buildDate":"2017-05-19 09:00 UTC","molgenisVersion":"1.0.0-SNAPSHOT"}

The molgenis version in this example points to the app version not the molgenis platform version.

Any application (for example https://github.com/molgenis/molgenis-EMX-downloader )that uses the version number returned by the request may make false assumptions about the molgenis-platformversion ( and emx / api versions).

A possible fix may be to include a seperate app-version-number and have the molgenisVersion version point to the molgenis platform version.

@bartcharbon
Copy link
Member

We probably want to return both the app version and the platform version.
This issue probably need to be adressed in the platform, I'll add and issue to link to this one in the molgenis repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants