Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQ fails intermittently in the CI #76

Open
pentateu opened this issue Oct 2, 2019 · 4 comments
Open

AMQ fails intermittently in the CI #76

pentateu opened this issue Oct 2, 2019 · 4 comments

Comments

@pentateu
Copy link
Member

pentateu commented Oct 2, 2019

@casskir the tests for AMQ fails intermittently in the CI
Check:
https://cloud.drone.io/moleculer-go/moleculer
Builds #400 and #401 failed at different points and #402 passed.
No code changes, I just manually restarted the build. So test sometimes pass and sometimes fails. On my local machine passed every-time, so it could be that in the CI server is a bit slower and cause these inconsistencies.

@casskir
Copy link
Contributor

casskir commented Oct 2, 2019

For fix it need to be merge moleculer-go/goemitter#1

@pentateu
Copy link
Member Author

pentateu commented Oct 3, 2019

Hi @casskir ,

I have merged the fixes on goemitter, thanks for catching and fixing that. I have also done a PR for the upstream project.

I have updated the go mod to point to the new goemitter version v1.0.2 , but the intermittent issues continue.

passed:
https://cloud.drone.io/moleculer-go/moleculer/405/1/4

Failed:
https://cloud.drone.io/moleculer-go/moleculer/406/1/4
https://cloud.drone.io/moleculer-go/moleculer/407/1/4

@pentateu
Copy link
Member Author

pentateu commented Oct 3, 2019

@casskir if u want to discuss this or anything else --> https://gitter.im/moleculer-go/moleculer

@pentateu
Copy link
Member Author

Tests are failing intermitent after AMQP transit was added.
The tests alwasy work when run isolated, but then the whole suit runs fails in the CI frequently. Local machine is rare, but also happens. So it seems that just adjusting the tests can make them robust and solid every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants