Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] [NFC] Rename SIMD.type to SIMD.D #3812

Closed
wants to merge 1 commit into from

Conversation

martinvuyk
Copy link
Contributor

Rename SIMD.type to SIMD.D. Part of #3811

Signed-off-by: martinvuyk <[email protected]>
@martinvuyk martinvuyk requested a review from a team as a code owner November 26, 2024 00:20
@gryznar
Copy link
Contributor

gryznar commented Nov 26, 2024

-1. This look strange and is inconsistent with size param.

@martinvuyk
Copy link
Contributor Author

martinvuyk commented Nov 26, 2024

size is a variable
D is a Type
I don't see your point

(if you still want to do SIMD.type it will work fine since it's an alias for D inside the struct)

@JoeLoser
Copy link
Collaborator

JoeLoser commented Dec 4, 2024

I understand the intent, but let's hold off on this PR until we discuss #3811 and whether it's something we want to do. I don't see a need to worry about this now. Let's lazily evaluate this when we get a type function and the like.

@martinvuyk martinvuyk closed this Dec 4, 2024
@martinvuyk martinvuyk deleted the rename-simd-type branch December 4, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants