Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Make List.__copyinit__() smarter. #3762

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

helehex
Copy link
Contributor

@helehex helehex commented Nov 10, 2024

This takes into account the null state of the underlying allocation.
This fixes the underlying cause of #2834, and should avoid more issues downstream.

@helehex helehex requested a review from a team as a code owner November 10, 2024 20:15
@JoeLoser JoeLoser requested review from lsh and ConnorGray November 14, 2024 14:50
Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix seems reasonable to me, WDYT @lsh @ConnorGray?

@JoeLoser
Copy link
Collaborator

JoeLoser commented Dec 4, 2024

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Dec 4, 2024
@skongum02 skongum02 deleted the branch modular:main January 29, 2025 18:58
@skongum02 skongum02 closed this Jan 29, 2025
@skongum02 skongum02 reopened this Jan 29, 2025
@skongum02 skongum02 changed the base branch from nightly to main January 29, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants