You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Groupby keword arguments should be passed to the pandas grouper when e.g. calculating group indices.
This is a small change to help alleviate a potentially breaking change in the future when pandas changes defaults.
In this case, observed will default to true in the future. So far I haven't run into an issue dealing with observed=False inside modin, but of course that might change.
The above will error showing the trace to one example in modin where this happens: DataFrameGroupBy._compute_index_grouped (ln 1568 in pandas/groupby.py.
As an example.
Expected Behavior
Modin groupby should play well with pandas groupby when specific groupby parameters are desired
Error Logs
No response
Installed Versions
INSTALLED VERSIONS
commit : 3e951a6
python : 3.10.12
python-bits : 64
OS : Linux
OS-release : 5.4.0-190-generic
Version : #210-Ubuntu SMP Fri Jul 5 17:03:38 UTC 2024
machine : x86_64
processor : x86_64
byteorder : little
LC_ALL : None
LANG : en_US.UTF-8
LOCALE : en_US.UTF-8
Modin version checks
I have checked that this issue has not already been reported.
I have confirmed this bug exists on the latest released version of Modin.
Reproducible Example
Issue Description
Groupby keword arguments should be passed to the pandas grouper when e.g. calculating group indices.
This is a small change to help alleviate a potentially breaking change in the future when pandas changes defaults.
In this case, observed will default to true in the future. So far I haven't run into an issue dealing with observed=False inside modin, but of course that might change.
The above will error showing the trace to one example in modin where this happens:
DataFrameGroupBy._compute_index_grouped
(ln 1568 inpandas/groupby.py
.As an example.
Expected Behavior
Modin groupby should play well with pandas groupby when specific groupby parameters are desired
Error Logs
No response
Installed Versions
INSTALLED VERSIONS
commit : 3e951a6
python : 3.10.12
python-bits : 64
OS : Linux
OS-release : 5.4.0-190-generic
Version : #210-Ubuntu SMP Fri Jul 5 17:03:38 UTC 2024
machine : x86_64
processor : x86_64
byteorder : little
LC_ALL : None
LANG : en_US.UTF-8
LOCALE : en_US.UTF-8
Modin dependencies
modin : 0.32.0
ray : 2.36.1
dask : 2024.8.2
distributed : 2024.8.2
pandas dependencies
pandas : 2.2.3
numpy : 1.26.4
pytz : 2024.1
dateutil : 2.9.0.post0
pip : 24.2
Cython : None
sphinx : None
IPython : 8.27.0
adbc-driver-postgresql: None
adbc-driver-sqlite : None
bs4 : 4.12.3
blosc : None
bottleneck : 1.4.2
dataframe-api-compat : None
fastparquet : 2024.2.0
fsspec : 2024.6.1
html5lib : None
hypothesis : None
gcsfs : None
jinja2 : 3.1.4
lxml.etree : 4.9.2
matplotlib : 3.9.2
numba : 0.60.0
numexpr : 2.10.1
odfpy : None
openpyxl : None
pandas_gbq : None
psycopg2 : None
pymysql : None
pyarrow : 16.1.0
pyreadstat : None
pytest : None
python-calamine : None
pyxlsb : None
s3fs : None
scipy : 1.14.1
sqlalchemy : None
tables : 3.10.1
tabulate : None
xarray : None
xlrd : None
xlsxwriter : None
zstandard : None
tzdata : 2023.3
qtpy : 2.4.1
pyqt5 : None
The text was updated successfully, but these errors were encountered: