Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise.done is deprecated. #37

Open
Helarga opened this issue Apr 11, 2020 · 1 comment
Open

Promise.done is deprecated. #37

Helarga opened this issue Apr 11, 2020 · 1 comment

Comments

@Helarga
Copy link

Helarga commented Apr 11, 2020

Atom now uses ES6 Promises instead of Q. Call promise.then instead of promise.done

Promise.done (<embedded>:1:727410)
Object.toggledocview (/home/helarga/.atom/packages/language-modelica/lib/modelica.coffee:144:10)
HTMLElement.subscriptions.add.atom.commands.add.language-modelica:toggledocview (/home/helarga/.atom/packages/language-modelica/lib/modelica.coffee:31:26)
CommandRegistry.handleCommandEvent (<embedded>:11:349290)
CommandRegistry.dispatch (<embedded>:11:347765)
AtomEnvironment.dispatchApplicationMenuCommand (<embedded>:1:725070)
@thorade
Copy link
Collaborator

thorade commented Apr 14, 2020

Thanks for the report. This sounds like you know how to fix it, would you like to also send a Pull Request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants