Commit 8d29bae
committed
Revert mount_path parameter from FastMCP (PR #540)
The mount_path parameter added in PR #540 was redundant because the
SSE transport already handles sub-path mounting via ASGI's standard
root_path mechanism.
When using Starlette's Mount("/path", app=mcp.sse_app()), Starlette
automatically sets root_path in the ASGI scope. The SseServerTransport
already uses this to construct the correct message endpoint path
(see sse.py lines 148-161).
This revert removes:
- mount_path setting from Settings class
- mount_path parameter from FastMCP.__init__
- mount_path parameter from run() and run_sse_async()
- _normalize_path() helper method
- mount_path parameter from sse_app()
- Related tests and redundant documentation
The README documentation is updated to show the correct way to mount
multiple MCP servers at different sub-paths, which works out of the box.1 parent 9f427f3 commit 8d29bae
File tree
3 files changed
+13
-154
lines changed- src/mcp/server/fastmcp
- tests/server/fastmcp
3 files changed
+13
-154
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1078 | 1078 | | |
1079 | 1079 | | |
1080 | 1080 | | |
1081 | | - | |
| 1081 | + | |
1082 | 1082 | | |
1083 | 1083 | | |
1084 | 1084 | | |
| |||
1614 | 1614 | | |
1615 | 1615 | | |
1616 | 1616 | | |
1617 | | - | |
| 1617 | + | |
1618 | 1618 | | |
1619 | 1619 | | |
1620 | 1620 | | |
| |||
1624 | 1624 | | |
1625 | 1625 | | |
1626 | 1626 | | |
1627 | | - | |
1628 | 1627 | | |
1629 | 1628 | | |
1630 | | - | |
1631 | | - | |
1632 | | - | |
1633 | | - | |
1634 | | - | |
1635 | | - | |
1636 | | - | |
1637 | | - | |
| 1629 | + | |
| 1630 | + | |
| 1631 | + | |
1638 | 1632 | | |
1639 | 1633 | | |
1640 | | - | |
1641 | 1634 | | |
1642 | 1635 | | |
1643 | | - | |
1644 | | - | |
1645 | | - | |
| 1636 | + | |
1646 | 1637 | | |
1647 | 1638 | | |
1648 | | - | |
1649 | | - | |
1650 | | - | |
1651 | | - | |
1652 | 1639 | | |
1653 | 1640 | | |
1654 | 1641 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
80 | 79 | | |
81 | 80 | | |
82 | 81 | | |
| |||
138 | 137 | | |
139 | 138 | | |
140 | 139 | | |
141 | | - | |
142 | 140 | | |
143 | 141 | | |
144 | 142 | | |
| |||
164 | 162 | | |
165 | 163 | | |
166 | 164 | | |
167 | | - | |
168 | 165 | | |
169 | 166 | | |
170 | 167 | | |
| |||
269 | 266 | | |
270 | 267 | | |
271 | 268 | | |
272 | | - | |
273 | 269 | | |
274 | 270 | | |
275 | 271 | | |
276 | 272 | | |
277 | 273 | | |
278 | | - | |
279 | 274 | | |
280 | 275 | | |
281 | 276 | | |
| |||
285 | 280 | | |
286 | 281 | | |
287 | 282 | | |
288 | | - | |
| 283 | + | |
289 | 284 | | |
290 | 285 | | |
291 | 286 | | |
| |||
749 | 744 | | |
750 | 745 | | |
751 | 746 | | |
752 | | - | |
| 747 | + | |
753 | 748 | | |
754 | 749 | | |
755 | 750 | | |
756 | | - | |
| 751 | + | |
757 | 752 | | |
758 | 753 | | |
759 | 754 | | |
| |||
779 | 774 | | |
780 | 775 | | |
781 | 776 | | |
782 | | - | |
783 | | - | |
784 | | - | |
785 | | - | |
786 | | - | |
787 | | - | |
788 | | - | |
789 | | - | |
790 | | - | |
791 | | - | |
792 | | - | |
793 | | - | |
794 | | - | |
795 | | - | |
796 | | - | |
797 | | - | |
798 | | - | |
799 | | - | |
800 | | - | |
801 | | - | |
802 | | - | |
803 | | - | |
804 | | - | |
805 | | - | |
806 | | - | |
807 | | - | |
808 | | - | |
| 777 | + | |
809 | 778 | | |
810 | 779 | | |
811 | | - | |
812 | | - | |
813 | | - | |
814 | | - | |
815 | | - | |
816 | | - | |
817 | | - | |
818 | | - | |
819 | | - | |
820 | | - | |
821 | | - | |
822 | | - | |
823 | | - | |
| 780 | + | |
824 | 781 | | |
825 | 782 | | |
826 | 783 | | |
827 | 784 | | |
828 | 785 | | |
829 | | - | |
830 | | - | |
831 | | - | |
832 | | - | |
833 | | - | |
| 786 | + | |
834 | 787 | | |
835 | 788 | | |
836 | 789 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | 51 | | |
133 | 52 | | |
134 | 53 | | |
| |||
0 commit comments