Skip to content

Commit 96385fd

Browse files
authored
docs: document non-pointer receiver for AudioContent (#660)
AudioContent should have had a non-pointer receiver, to be consistent with other content types. Add this to our log of rough edges to reconsider for v2. Fixes #641
1 parent 21fb03d commit 96385fd

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

docs/rough_edges.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,6 @@ v2.
2323
other notification param types.
2424
- Similarly, `ProgressNotificationParams` should probably have been
2525
`ProgressParams`.
26+
27+
- `AudioContent.MarshalJSON` should have had a pointer receiver, to be
28+
consistent with other content types.

internal/docs/rough_edges.src.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,6 @@ v2.
2222
other notification param types.
2323
- Similarly, `ProgressNotificationParams` should probably have been
2424
`ProgressParams`.
25+
26+
- `AudioContent.MarshalJSON` should have had a pointer receiver, to be
27+
consistent with other content types.

0 commit comments

Comments
 (0)