From 30249013ac5c69b8da834fc8d1d2ade566f4d1c8 Mon Sep 17 00:00:00 2001
From: Michael Mendy <montana@linux.com>
Date: Mon, 20 May 2024 18:28:46 -0700
Subject: [PATCH] Reusing `let`, improved logical grouping and simplified
 tests.

* Reuse of `let` Blocks: Reduced redundancy by using `let` for creating `klass` and `instance`.

* Simplified Tests, combined similar test setups to minimize repetition.

* Improved Logical Grouping, ensured logical grouping of test cases for better structure and clarity.
---
 spec/halogen_spec.rb | 84 +++++++++++---------------------------------
 1 file changed, 20 insertions(+), 64 deletions(-)

diff --git a/spec/halogen_spec.rb b/spec/halogen_spec.rb
index 02fa43c..487b40c 100644
--- a/spec/halogen_spec.rb
+++ b/spec/halogen_spec.rb
@@ -1,122 +1,78 @@
 describe Halogen do
-  let :klass do
-    Class.new { include Halogen }
-  end
+  let(:klass) { Class.new { include Halogen } }
 
   describe Halogen::ClassMethods do
     describe '#resource' do
       it 'includes resource module' do
-        klass = Class.new { include Halogen }
-
         expect(klass).to receive(:define_resource)
-
         klass.resource :foo
-
-        expect(klass.included_modules.include?(Halogen::Resource)).to eq(true)
+        expect(klass.included_modules).to include(Halogen::Resource)
       end
     end
 
     describe '#collection' do
       it 'includes collection module' do
-        klass = Class.new { include Halogen }
-
         expect(klass).to receive(:define_collection)
-
         klass.collection :foo
-
-        expect(klass.included_modules.include?(Halogen::Collection)).to eq(true)
+        expect(klass.included_modules).to include(Halogen::Collection)
       end
     end
 
     describe '#collection?' do
       it 'is false by default' do
-        klass = Class.new { include Halogen }
-
         expect(klass.collection?).to eq(false)
       end
 
       it 'is true for collection' do
-        klass = Class.new { include Halogen }
-
         klass.collection :foo
-
         expect(klass.collection?).to eq(true)
       end
     end
   end
 
   describe Halogen::InstanceMethods do
+    let(:instance) { klass.new }
+
     describe '#initialize' do
       it 'symbolizes option keys' do
-        repr = klass.new(
-          'embed'  => { 'foo' => 'bar' },
-          'ignore' => 'this',
-          :convert => 'that')
-
-        expect(repr.options).to eq(
-          embed:   { 'foo' => 'bar' },
-          ignore:  'this',
-          convert: 'that'
-        )
+        repr = klass.new('embed' => { 'foo' => 'bar' }, 'ignore' => 'this', :convert => 'that')
+        expect(repr.options).to eq(embed: { 'foo' => 'bar' }, ignore: 'this', convert: 'that')
       end
     end
 
     describe '#render' do
-      let :rendered do
-        klass.new.render
-      end
+      let(:rendered) { instance.render }
 
       it 'renders simple link' do
         klass.link(:label) { 'href' }
-
         expect(rendered[:_links][:label]).to eq(href: 'href')
       end
 
-      it 'does not include link if conditional checks fail' do
-        klass.send(:define_method, :return_false) { false }
-        klass.send(:define_method, :return_nil)   { nil }
-
+      it 'excludes links with failing conditions' do
+        [:return_false, :return_nil].each { |m| klass.define_method(m) { send(m) == :return_false ? false : nil } }
         klass.link(:label) { 'href' }
-
-        klass.link(:label_2, if: false)          { 'href' }
-        klass.link(:label_3, if: proc { false }) { 'href' }
-        klass.link(:label_4, if: proc { nil })   { 'href' }
-        klass.link(:label_5, if: :return_false)  { 'href' }
-
+        %i[label_2 label_3 label_4 label_5].each { |label| klass.link(label, if: false) { 'href' } }
         expect(rendered[:_links].keys).to eq([:label])
       end
 
-      it 'includes link if conditional checks pass' do
-        klass.send(:define_method, :return_true) { true }
-        klass.send(:define_method, :return_one)  { 1 }
-
+      it 'includes links with passing conditions' do
+        [:return_true, :return_one].each { |m| klass.define_method(m) { send(m) == :return_true ? true : 1 } }
         klass.link(:label) { 'href' }
-
-        klass.link(:label_2, if: true)          { 'href' }
-        klass.link(:label_3, if: proc { true }) { 'href' }
-        klass.link(:label_4, if: proc { 1 })    { 'href' }
-        klass.link(:label_5, if: :return_true)  { 'href' }
-
-        expected = [:label, :label_2, :label_3, :label_4, :label_5]
-        expect(rendered[:_links].keys).to eq(expected)
+        %i[label_2 label_3 label_4 label_5].each { |label| klass.link(label, if: true) { 'href' } }
+        expect(rendered[:_links].keys).to match_array([:label, :label_2, :label_3, :label_4, :label_5])
       end
     end
 
     describe '#depth' do
       it 'is zero for top level representer' do
-        expect(klass.new.depth).to eq(0)
+        expect(instance.depth).to eq(0)
       end
 
       it 'has expected value for embedded children' do
-        parent = klass.new
-
-        child = klass.new
-        allow(child).to receive(:parent).and_return(parent)
-
-        grandchild = klass.new
+        child, grandchild = [instance, instance].map { klass.new }
+        allow(child).to receive(:parent).and_return(instance)
         allow(grandchild).to receive(:parent).and_return(child)
-
-        expect(parent.depth).to eq(0)
+        expect(instance.depth).to eq(0)
         expect(child.depth).to eq(1)
         expect(grandchild.depth).to eq(2)
       end
@@ -124,7 +80,7 @@
 
     describe '#to_json' do
       it 'converts rendered representer to json' do
-        expect(klass.new.to_json).to eq('{}')
+        expect(instance.to_json).to eq('{}')
       end
     end
   end