Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata-indexer: open graph images may have CORS rules or be broken links #116

Open
davidfurlong opened this issue Dec 8, 2023 · 1 comment
Open

metadata-indexer: open graph images may have CORS rules or be broken links #116

davidfurlong opened this issue Dec 8, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@davidfurlong
Copy link
Contributor

Embeds may have metadata that has a broken link, we should make the Mods that render them fail more gracefully and not render a broken image square. An example is warpcast links which use a private og:image, perhaps to prevent sites like twitter from rendering the cast preview
@davidfurlong davidfurlong added the bug Something isn't working label Dec 8, 2023
@davidfurlong
Copy link
Contributor Author

Fix is here: https://warpcast.com/df/0xf692e73b

@davidfurlong davidfurlong changed the title Indexer: open graph images may have CORS rules or be broken links metadata-indexer: open graph images may have CORS rules or be broken links Dec 9, 2023
@stephancill stephancill mentioned this issue Dec 19, 2023
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidfurlong