Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Rename validatePlugins to validatePluginsSkipkit to avoid task name clash with Gradle 6.x #877

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rename validatePlugins to validatePluginsSkipkit to avoid task name clash with Gradle 6.x #877

wants to merge 2 commits into from

Conversation

vlsi
Copy link

@vlsi vlsi commented Jul 24, 2020

This fixes #876 (GradlePortalReleasePlugin: Cannot add task 'validatePlugins' as a task with that name already exists)

@vlsi vlsi marked this pull request as ready for review July 24, 2020 09:45
@vlsi vlsi changed the title Gradle 6.x compatibility: cannot add task 'validatePlugins' as a task with that name already exists Rename validatePlugins to validatePluginsSkipkit to avoid task name clash with Gradle 6.x Jul 24, 2020
@vlsi
Copy link
Author

vlsi commented Jul 24, 2020 •
edited
Loading

ShipkitJavaIntegTest fails with Gradle 6.5, and the cause seems to be tasks returned in the different order.

I don't know what does the test verify, so I don't know how to heal it.

@mockitoguy , can you please clarify?

Expected:

...
:api:generatePomFileForJavaLibraryPublication
:api:compileJava
:api:processResources
:api:classes
:api:jar
:api:javadoc
:api:javadocJar
...

Actual:

...
:api:compileJava
:api:processResources
:api:classes
:api:jar
:api:generateMetadataFileForJavaLibraryPublication
:api:generatePomFileForJavaLibraryPublication
...

@vlsi
Copy link
Author

vlsi commented Jul 24, 2020

One of the workarounds could be "ignore :generatePom and :generateMetadata" tasks in skippedTaskPathsGradleBugWorkaround. The tasks do not seem to be important much, and they seem to be the only ones that produce unordered results.

WDYT?

@vlsi
Skip :generatePom... and :generateMetadata... tasks in test assertions
32ebd6c 
The task depend on Gradle version, and their order is not stable.
@mockitoguy
Copy link
Member

@vlsi, we are going to put the project in maintenance mode soon. The new plugins are:

Check out the new plugins. Would they work for you?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GradlePortalReleasePlugin: Cannot add task 'validatePlugins' as a task with that name already exists
2 participants
@vlsi @mockitoguy