Move away from Lerna? #1600
-
I'm taking over as lead maintainer of MobX-State-Tree, and one thing I'd like to do is simplify the maintenance of MST in general. In most of my open source libraries, I've gone away from Lerna and had individual projects for every repo, released with semantic-release. This has worked pretty well overall. As far as I can tell, Lerna isn't doing a lot for us here other than holding some rather outdated examples and mst-middleware. And it's getting in the way as I start working within the repo in the now-familiar ways that Lerna gets in the way (namely not playing well with tooling like semantic-release). My proposal:
Does anyone have objections to this? cc @mweststrate |
Beta Was this translation helpful? Give feedback.
Replies: 5 comments 2 replies
-
I intend to merge as many PRs as make sense before doing this, as they'll all be conflicted like crazy once we do. |
Beta Was this translation helpful? Give feedback.
-
Hey Jamon. As you might have noticed we have started using https://github.com/atlassian/changesets in MobX monorepo and it's a great and simple system. In my opinion, it's superior to Lerna is indeed a bit of an outdated tool. The changesets are a great replacement for it as well. In a long run, once all issues and PRs are resolved here, it might be worth considering moving these packages to |
Beta Was this translation helpful? Give feedback.
-
If memory serves me well Lerna served two purposes:
I think 2 isn't really needed anymore, especially if releases are automated. For 1, this can be solved with less obtrusive solutions than lerna, like workspaces, relative-deps or linking in post install scripts. Or even not linking automatically at all; it is a bit less urgent now the library is in a mature state So yeah, feel free to drop Lerna :) |
Beta Was this translation helpful? Give feedback.
-
I think that would be quite confusing in the issue tracker? I noticed mobx
and mobx-react tend to blend much more together into one thing in peoples
mind, while a lot of mobx specific problems / questions dont apply to MST
and vice versa
…On Wed, Nov 18, 2020 at 7:16 AM Daniel K. ***@***.***> wrote:
Sure, if you are comfortable with it, it's fine.
And what do you think about eventually moving the repo to our monorepo?
You could still be responsible for issues/PRs toward it there of course.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1600 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN4NBCTOVBY2OFROOBPKJDSQNYGHANCNFSM4TX76SOQ>
.
|
Beta Was this translation helpful? Give feedback.
-
Done and done. Thanks all! |
Beta Was this translation helpful? Give feedback.
If memory serves me well Lerna served two purposes:
I think 2 isn't really needed anymore, especially if releases are automated.
For 1, this can be solved with less obtrusive solutions than lerna, like workspaces, relative-deps or linking in post install scripts. Or even not linking automatically at all; it is a bit less urgent now the library is in a mature state
So yeah, feel free to drop Lerna :)