Firebase do not unlink file after fail upload file.

[leybme]

I had a problem that if i use the setFile menthod to send file to the Firebase from flash.
If the send status fail, the Firebase cannot send that file again, it warning: the file is open
My question: how to know the current file is opening by Firebase and is there any method for close all current file is open by FB ?

[mobizt]

Please update the library and try again.

If the problem is still persisted after updated, please provide the minimal but complete code to reproduce the issue.

[leybme]

Thank for your response,
Here are the code i had try to repoduce the issue

/**
 * Created by K. Suwatchai (Mobizt)
 *
 * Email: [email protected]
 *
 * Github: https://github.com/mobizt/Firebase-ESP32
 *
 * Copyright (c) 2023 mobizt
 *
 */

// This example shows how to store and read binary data from file on Flash memory to database.

#include <Arduino.h>
#include <WiFi.h>
#include <FirebaseESP32.h>

// Provide the token generation process info.
#include <addons/TokenHelper.h>

// Provide the RTDB payload printing info and other helper functions.
#include <addons/RTDBHelper.h>

// /* 1. Define the WiFi credentials */
// #define WIFI_SSID "WIFI_AP"
// #define WIFI_PASSWORD "WIFI_PASSWORD"

// // For the following credentials, see examples/Authentications/SignInAsUser/EmailPassword/EmailPassword.ino

// /* 2. Define the API Key */
// #define API_KEY "API_KEY"

// /* 3. Define the RTDB URL */
// #define DATABASE_URL "URL" //<databaseName>.firebaseio.com or <databaseName>.<region>.firebasedatabase.app

// /* 4. Define the user Email and password that alreadey registerd or added in your project */
// #define USER_EMAIL "USER_EMAIL"
// #define USER_PASSWORD "USER_PASSWORD"


// Define Firebase Data object

FirebaseData fbdo;

FirebaseAuth auth;
FirebaseConfig config;

bool taskCompleted = false;

fs::File file;

/*

To use LittleFS file system instead of SPIFFS. add #define USE_LITTLEFS to FirebaseFS.h
and replace all SPIFFS class in this sketch with LittleFS

*/

void setup() {

  Serial.begin(115200);
  Serial.println();
  Serial.println();

  WiFi.begin(WIFI_SSID, WIFI_PASSWORD);
  Serial.print("Connecting to Wi-Fi");
  while (WiFi.status() != WL_CONNECTED) {
    Serial.print(".");
    delay(300);
  }
  Serial.println();
  Serial.print("Connected with IP: ");
  Serial.println(WiFi.localIP());
  Serial.println();

  Serial.printf("Firebase Client v%s\n\n", FIREBASE_CLIENT_VERSION);

  /* Assign the api key (required) */
  config.api_key = API_KEY;

  /* Assign the user sign in credentials */
  auth.user.email = USER_EMAIL;
  auth.user.password = USER_PASSWORD;

  /* Assign the RTDB URL (required) */
  config.database_url = DATABASE_URL;

  /* Assign the callback function for the long running token generation task */
  config.token_status_callback = tokenStatusCallback;  // see addons/TokenHelper.h

  // Comment or pass false value when WiFi reconnection will control by your code or third party library e.g. WiFiManager
  Firebase.reconnectNetwork(true);

  // Since v4.4.x, BearSSL engine was used, the SSL buffer need to be set.
  // Large data transmission may require larger RX buffer, otherwise connection issue or data read time out can be occurred.
  fbdo.setBSSLBufferSize(4096 /* Rx buffer size in bytes from 512 - 16384 */, 1024 /* Tx buffer size in bytes from 512 - 16384 */);

  // Or use legacy authenticate method
  // config.database_url = DATABASE_URL;
  // config.signer.tokens.legacy_token = "<database secret>";

  // To connect without auth in Test Mode, see Authentications/TestMode/TestMode.ino

  Firebase.begin(&config, &auth);

  if (!DEFAULT_FLASH_FS.begin()) {
    Serial.println("SPIFFS/LittleFS initialization failed.");
    Serial.println("For Arduino IDE, please select flash size from menu Tools > Flash size");
    return;
  }

  // Delete demo files
  if (DEFAULT_FLASH_FS.exists("/file1.txt"))
    DEFAULT_FLASH_FS.remove("/file1.txt");

  if (DEFAULT_FLASH_FS.exists("/file2.txt"))
    DEFAULT_FLASH_FS.remove("/file2.txt");

  // Write demo data to file
  file = DEFAULT_FLASH_FS.open("/file1.txt", "w");
  uint8_t v = 0;
  for (int i = 0; i < 512; i++) {
    file.write(v);
    v++;
  }

  file.close();

  if (Firebase.ready() && !taskCompleted) {
    taskCompleted = true;

    // File name must be in 8.3 DOS format (max. 8 bytes file name and 3 bytes file extension)
    Serial.println("\nSet file...");
    if (!Firebase.setFile(fbdo, StorageType::FLASH, "test/file/data", "/file1.txt", rtdbUploadCallback /* callback function*/))
      Serial.println(fbdo.errorReason());

    Serial.println("\nGet file...");
    if (!Firebase.getFile(fbdo, StorageType::FLASH, "test/file/data", "/file2.txt", rtdbDownloadCallback /* callback function*/))
      Serial.println(fbdo.errorReason());

    if (fbdo.httpCode() == FIREBASE_ERROR_HTTP_CODE_OK) {
      // Readout the downloaded file
      file = DEFAULT_FLASH_FS.open("/file2.txt", "r");
      int i = 0;

      while (file.available()) {
        if (i > 0 && i % 16 == 0)
          Serial.println();

        uint8_t v = file.read();

        if (v < 16)
          Serial.print("0");

        Serial.print(v, HEX);
        Serial.print(" ");
        i++;
      }

      Serial.println();
      file.close();
    }
  }
  //Try to remove file1
  Serial.println("Try to remove file1");
  DEFAULT_FLASH_FS.remove("/file1.txt");
  if (!DEFAULT_FLASH_FS.exists("/file1.txt")) Serial.println("Remove success");
  // Write demo data to file
  file = DEFAULT_FLASH_FS.open("/file1.txt", "w");
  v = 0;
  for (int i = 0; i < 512; i++) {
    file.write(v);
    v++;
  }

  file.close();
  Serial.println("Delay for hope the tcp socket timeout");
  delay(150000);  //Delay for tcp socket timeout
  if (Firebase.ready()) {
    taskCompleted = true;

    // File name must be in 8.3 DOS format (max. 8 bytes file name and 3 bytes file extension)
    Serial.println("\nSet file...");
    if (!Firebase.setFile(fbdo, StorageType::FLASH, "test/file/data", "/file1.txt", rtdbUploadCallback /* callback function*/))
      Serial.println(fbdo.errorReason());
    Serial.println("Try to remove file1 again");
    DEFAULT_FLASH_FS.remove("/file1.txt");
    if (!DEFAULT_FLASH_FS.exists("/file1.txt")) Serial.println("Remove success");
  }
}

// The Firebase download callback function
void rtdbDownloadCallback(RTDB_DownloadStatusInfo info) {
  if (info.status == firebase_rtdb_download_status_init) {
    Serial.printf("Downloading file %s (%d) to %s\n", info.remotePath.c_str(), info.size, info.localFileName.c_str());
  } else if (info.status == firebase_rtdb_download_status_download) {
    Serial.printf("Downloaded %d%s\n", (int)info.progress, "%");
  } else if (info.status == firebase_rtdb_download_status_complete) {
    Serial.println("Download completed\n");
  } else if (info.status == firebase_rtdb_download_status_error) {
    Serial.printf("Download failed, %s\n", info.errorMsg.c_str());
  }
}

// The Firebase upload callback function
void rtdbUploadCallback(RTDB_UploadStatusInfo info) {
  if (info.status == firebase_rtdb_upload_status_init) {
    Serial.printf("Uploading file %s (%d) to %s\n", info.localFileName.c_str(), info.size, info.remotePath.c_str());
  } else if (info.status == firebase_rtdb_upload_status_upload) {
    Serial.printf("Uploaded %d%s\n", (int)info.progress, "%");
  } else if (info.status == firebase_rtdb_upload_status_complete) {
    Serial.println("Upload completed\n");
  } else if (info.status == firebase_rtdb_upload_status_error) {
    Serial.printf("Upload failed, %s\n", info.errorMsg.c_str());
  }
}

void loop() {

  // Firebase.ready() should be called repeatedly to handle authentication tasks.
}

[mobizt]

You should post the result of library updates because this issue should not exist in the latest version.

[leybme]

I am using version 4.4.10, is this newest version ?

[mobizt]

This is not library issue but memory issue on filesystem related to memory allocation failure in some outdated core SDK.

This issue causes the filesystem write failure silently.

You should update ESP32 Arduino Core SDK to fix this issue.

[leybme]

Thanks, i will try