Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of v16.datatypes.SampledValue.context is incorrect #421

Closed
OrangeTux opened this issue Feb 16, 2023 · 3 comments
Closed

Type of v16.datatypes.SampledValue.context is incorrect #421

OrangeTux opened this issue Feb 16, 2023 · 3 comments
Labels
bug Something isn't working For inclusion in release 1.0.0

Comments

@OrangeTux
Copy link
Contributor

The specification allows the field to be optional. But the library requires it.

ocpp/ocpp/v16/datatypes.py

Line 107 in 0adf945

context: ReadingContext

@Jared-Newell-Mobility Jared-Newell-Mobility added the bug Something isn't working label Sep 8, 2023
@Jared-Newell-Mobility
Copy link
Contributor

Good catch - 7.43 - Optional. Type of detail value: start, end or sample. Default = “Sample.Periodic”

@Jared-Newell-Mobility
Copy link
Contributor

Satisfied with PR - #495 - For inclusion in next major release

@Jared-Newell-Mobility
Copy link
Contributor

Referenced in #174

OrangeTux added a commit that referenced this issue Jan 15, 2024
@OrangeTux
Merge branch 'master' into Type-of-v16.datatypes.SampledValue.context…
342dd71 
…-is-incorrect-#421
Merged
Jared-Newell-Mobility added a commit that referenced this issue Jan 17, 2024
@Jared-Newell-Mobility
Bump 0.26.0 (#572)
9f1ab29 
- [#544](#544) Pass
`Call.unique_id` to the `on` and `after` routing handlers.
- [#559](#559) Update
project dependencies as of 22-12-2023
- [#447](#447) Make
formatting of enums in py3.11 consistent with earlier Python versions
- [#421](#421) Type of
v16.datatypes.SampledValue.context is incorrect
RoaringDev1203 added a commit to RoaringDev1203/Cratus-OCPP that referenced this issue Aug 27, 2024
@RoaringDev1203
Bump 0.26.0 (#572)
82a0dd0 
- [#544](mobilityhouse/ocpp#544) Pass
`Call.unique_id` to the `on` and `after` routing handlers.
- [#559](mobilityhouse/ocpp#559) Update
project dependencies as of 22-12-2023
- [#447](mobilityhouse/ocpp#447) Make
formatting of enums in py3.11 consistent with earlier Python versions
- [#421](mobilityhouse/ocpp#421) Type of
v16.datatypes.SampledValue.context is incorrect
ajmirsky pushed a commit to ajmirsky/ocpp that referenced this issue Nov 26, 2024
@Jared-Newell-Mobility
Bump 0.26.0 (mobilityhouse#572)
f2d93f3 
- [mobilityhouse#544](mobilityhouse#544) Pass
`Call.unique_id` to the `on` and `after` routing handlers.
- [mobilityhouse#559](mobilityhouse#559) Update
project dependencies as of 22-12-2023
- [mobilityhouse#447](mobilityhouse#447) Make
formatting of enums in py3.11 consistent with earlier Python versions
- [mobilityhouse#421](mobilityhouse#421) Type of
v16.datatypes.SampledValue.context is incorrect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working For inclusion in release 1.0.0
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OrangeTux @Jared-Newell-Mobility