Skip to content

Commit 3392595

Browse files
Remove std dependency from rand in mc-sgx-core-types
Also omit `mc-sgx-core-types` from cargo nono checks since cargo nono does not resolve this correctly. hobofan/cargo-nono#64 has a suggestion to help alleviate these occurrences, but it's been dormant for a year.
1 parent f64fd89 commit 3392595

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

.github/workflows/lint.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,13 @@ jobs:
3434
- name: install nono
3535
run: cargo install cargo-nono
3636
# `mc-sgx-quote-verify` should be `no_std`, but it isn't yet. See #34
37+
# `mc-sgx-core-types` should be `no_std`, but cargo nono doesn't parse
38+
# correctly, see https://github.com/hobofan/cargo-nono/pull/64 for a
39+
# suggested improvement
3740
- run: |
3841
cargo metadata --no-deps --format-version=1 | \
3942
jq -r '.packages[].name' | \
40-
grep -v -e mc-sgx-core-build -e mc-sgx-dcap-quoteverify-sys -e mc-sgx-dcap-ql-sys -e mc-sgx-quote-verify -e mc-sgx-urts -e mc-sgx-capable-sys | \
43+
grep -v -e mc-sgx-core-types -e mc-sgx-core-build -e mc-sgx-dcap-quoteverify-sys -e mc-sgx-dcap-ql-sys -e mc-sgx-quote-verify -e mc-sgx-urts -e mc-sgx-capable-sys | \
4144
xargs -n1 sh -c 'cargo nono check --package $0 || exit 255'
4245
markdown-lint:
4346
runs-on: ubuntu-20.04

core/types/Cargo.toml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,15 @@ edition = "2021"
55

66
[dependencies]
77
mc-sgx-core-sys-types = { path = "../sys/types", version = "=0.1.0" }
8-
rand = "0.8.5"
8+
rand = { version = "0.8.5", default-features = false }
99
serde = { version = "1.0.143", default-features = false, features = ["derive"], optional = true }
1010

1111
[features]
1212
serde = ["dep:serde"]
1313

1414
[dev-dependencies]
1515
yare = "1.0.1"
16+
17+
[dev-dependencies.rand]
18+
version = "0.8.5"
19+
features = ["std"]

0 commit comments

Comments
 (0)