[RFC] measurement for device commands #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanjeetsingh150
approved these changes
Nov 21, 2024
amanjeetsingh150
force-pushed
the
add-metrics
branch
from
248d610 to
e98c51b
Compare
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this pull request
Dec 9, 2024
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to introduce micrometer management across the board, starting w/ individual commands on ios and android. This will allow us to identify potential bottlenecks, errors at the command level, etc
The default implementation is a noop - it won't collect or send metrics anywhere. Users of maestro (eg robin itself) can hook them up so we get metrics for tests that run in the platform.
The idea is to also auto-instrument http requests (using okhttp), such that we can tell cases where retries are happening more than they should, etc