Allow AdbServer.list() to work with multiple adb devices #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select adb device by serial number
This was referenced Dec 4, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows dadb to work with multiple devices attached to adb, and seems to work for my real test case against the Maestro test framework.
To allow the tests to run while multiple devices are attached, I added a 'first:' deviceQualifier - it can be given a regex to select for and against emulators and remote machines.
Despite my concerns in #64 (comment) I think this is an OK solution: it's vanishingly unlikely the device will reconnect between listing, and most adb users work from -s anyway.