Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataset.json timepoints #778

Closed
tischi opened this issue Jun 3, 2022 · 4 comments
Closed

dataset.json timepoints #778

tischi opened this issue Jun 3, 2022 · 4 comments
Labels
discussion

Comments

@tischi
Copy link
Contributor

tischi commented Jun 3, 2022 •
edited
Loading

I think we may not need timepoints in dataset.json anymore.
See: #777
@constantinpape
Copy link
Contributor

Ok, we can eventually get rid of them, but we need to discuss versioning of the spec a bit beforehand, also with #772 and #771 in mind.

@constantinpape
Copy link
Contributor

@tischi: should we actually remove the timepoints field for the new spec update?
I have created mobie/arabidopsis-root-lm-project#8 so that you can check in mobie3. (I have left the timepoints field in for now, but you could check if everything works if you load the data without it.)

@tischi
Copy link
Contributor Author

tischi commented Oct 14, 2022

You can remove it. I just checked an I don't use it in the code anymore.

@constantinpape
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tischi @constantinpape