Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

bundle very large #69

Open
yocontra opened this issue Nov 7, 2018 · 4 comments
Open

bundle very large #69

yocontra opened this issue Nov 7, 2018 · 4 comments

Comments

@yocontra
Copy link

yocontra commented Nov 7, 2018

image

this is the largest dependency in our project, but looking at the code i can't figure out why it needs to be.

sure, the frequency list is large (and maybe that should be another ticket about making a version that doesn't have that included) but there seems to be a lot of other stuff in the bundle that doesn't need to be there (node process shims, react and prop-types is bundled, etc.).

@mmw
Copy link
Owner

mmw commented Nov 8, 2018

Its expected to be larger because of zxcvbn but it sounds like maybe the dev bundle got published by accident. Will try to find some time soon to look into it

@danawoodman
Copy link

Same issue here, @mmw is this expected?

@mmw
Copy link
Owner

mmw commented Apr 2, 2019

zxcvbn is a large library and I think thats causing the large bundle size, I haven't had time to confirm/investigate though

I'd suggest splitting your app and only using react-pass-strength where you actually need it or dynamically importing it

@yocontra
Copy link
Author

yocontra commented Aug 15, 2019

@mmw Maybe have a lighter-weight export available that doesn't use zxcvbn? zxcvbn is great but may be overkill for most cases.

Something like react-password-strength/lite based on one of these maybe?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants