Skip to content

Introduce a different review process for design proposals #1012

Closed
@qinsoon

Description

@qinsoon

Steve suggested that design has profound impact, and a design proposal cannot be well evaluated by our CI, nor our normal code review process. We should have a different review process for design proposals. Like Rust's RFC, and OpenJDK's JEP. The idea is to have a more vigorous review process to deal with design changes, and to avoid wasting efforts on implementation before the design is approved.

It is yet unclear: 1. what should be categorised as a design change, and 2. what process we should adopt for design proposals.

Activity

added
A-metaArea: Meta issues for the repository
on Nov 3, 2023
added
P-highPriority: High. A high-priority issue should be fixed as soon as possible.
on Nov 6, 2023
qinsoon

qinsoon commented on Jan 1, 2024

@qinsoon
MemberAuthor

We introduced MEP in #1056, and #1041 tracks our discussion about MEP. This issue can be closed.

Answering the two questions in the issues:

  1. What should be categorised as a design change: MEP focuses on changes that may have future impacts on the project.
  2. What process we should adopt for design proposals: Unlike normal PR reviews which is only reviewed by certain reviewers, MEP reviews need the consensus from the MMTk team. See https://github.com/mmtk/mmtk-core/blob/master/docs/contribute/mep.md#mep-reviewing-process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-metaArea: Meta issues for the repositoryP-highPriority: High. A high-priority issue should be fixed as soon as possible.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @qinsoon@k-sareen

        Issue actions

          Introduce a different review process for design proposals · Issue #1012 · mmtk/mmtk-core