Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to run tests in profile mode #64

Open
vishna opened this issue Aug 28, 2019 · 4 comments
Open

Add option to run tests in profile mode #64

vishna opened this issue Aug 28, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@vishna
Copy link

vishna commented Aug 28, 2019

Currently all tests run in debug mode by default with no option to change it. My main goal using this library and AWS Device farm is collecting profiling reports.

@mmcc007 mmcc007 added the question Further information is requested label Aug 28, 2019
@mmcc007
Copy link
Owner

mmcc007 commented Aug 28, 2019

Should be possible to get working (pending no unexpected Device Farm issues). Haven't used profiling programmatically, so there's that. I assume you end-up with some log artifacts to include in the download from Device Farm.

If lucky, just adding the option to build in profile mode should be enough to get it going.

To help with my assumptions, can you describe a little about the workflow in your use case?

@vishna
Copy link
Author

vishna commented Aug 29, 2019

If lucky, just adding the option to build in profile mode should be enough to get it going.

This is how I run it locally:

flutter drive --profile --target=test_driver/app.dart

...any place in yaml where I could add this? 😃

@mmcc007 mmcc007 removed the question Further information is requested label Aug 29, 2019
@mmcc007
Copy link
Owner

mmcc007 commented Aug 29, 2019

When running on device farm you're generally required to upload a signed .ipa or .apk. Found a way to get debug apps packaged as signed .ipa/.apk.

If the same packaging approach works for profile apps, then can move forward. Will have to do some manual testing on device farm to confirm that an app built in profile mode can run profile integration tests.

From there, can integrate into sylph.

Since profiling generates test artifacts, will require implementing #22.

So the profile workflow in sylph should look something like:

  1. Get profile config from config file
    Setting profile mode requires setting a flag and artifact dirname in config file
  2. Build and upload profile .ipa/.apk
  3. Run the integration tests on device farm
    The integration tests will gather profiling and write to a directory
  4. Download profiling artifacts

Does this workflow fit your use case? Any changes?

@mmcc007 mmcc007 added the question Further information is requested label Aug 29, 2019
@vishna
Copy link
Author

vishna commented Aug 30, 2019

That's exactly what I'm going for.

@mmcc007 mmcc007 added enhancement New feature or request and removed question Further information is requested labels Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants