Skip to content

Commit 4cbbd1d

Browse files
committed
Merge tag 'fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
Pull ARM SoC fix from Olof Johansson: "A late-arriving fix for musb on OMAP4, resolving an issue where the musb IP won't be clocked and thus not functional. Small in scope, most of the lines changed is a longish comment." * tag 'fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc: ARM: OMAP4: hwmod data: make 'ocp2scp_usb_phy_phy_48m" as the main clock
2 parents 3c0b9de + d21be23 commit 4cbbd1d

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

arch/arm/mach-omap2/omap_hwmod_44xx_data.c

+11-7
Original file line numberDiff line numberDiff line change
@@ -2714,16 +2714,22 @@ static struct omap_ocp2scp_dev ocp2scp_dev_attr[] = {
27142714
{ }
27152715
};
27162716

2717-
static struct omap_hwmod_opt_clk ocp2scp_usb_phy_opt_clks[] = {
2718-
{ .role = "48mhz", .clk = "ocp2scp_usb_phy_phy_48m" },
2719-
};
2720-
27212717
/* ocp2scp_usb_phy */
27222718
static struct omap_hwmod omap44xx_ocp2scp_usb_phy_hwmod = {
27232719
.name = "ocp2scp_usb_phy",
27242720
.class = &omap44xx_ocp2scp_hwmod_class,
27252721
.clkdm_name = "l3_init_clkdm",
2726-
.main_clk = "func_48m_fclk",
2722+
/*
2723+
* ocp2scp_usb_phy_phy_48m is provided by the OMAP4 PRCM IP
2724+
* block as an "optional clock," and normally should never be
2725+
* specified as the main_clk for an OMAP IP block. However it
2726+
* turns out that this clock is actually the main clock for
2727+
* the ocp2scp_usb_phy IP block:
2728+
* http://lists.infradead.org/pipermail/linux-arm-kernel/2012-September/119943.html
2729+
* So listing ocp2scp_usb_phy_phy_48m as a main_clk here seems
2730+
* to be the best workaround.
2731+
*/
2732+
.main_clk = "ocp2scp_usb_phy_phy_48m",
27272733
.prcm = {
27282734
.omap4 = {
27292735
.clkctrl_offs = OMAP4_CM_L3INIT_USBPHYOCP2SCP_CLKCTRL_OFFSET,
@@ -2732,8 +2738,6 @@ static struct omap_hwmod omap44xx_ocp2scp_usb_phy_hwmod = {
27322738
},
27332739
},
27342740
.dev_attr = ocp2scp_dev_attr,
2735-
.opt_clks = ocp2scp_usb_phy_opt_clks,
2736-
.opt_clks_cnt = ARRAY_SIZE(ocp2scp_usb_phy_opt_clks),
27372741
};
27382742

27392743
/*

0 commit comments

Comments
 (0)