Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog buttons does not have equal width #149

Open
forimbajosh21 opened this issue Oct 25, 2022 · 2 comments
Open

Dialog buttons does not have equal width #149

forimbajosh21 opened this issue Oct 25, 2022 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@forimbajosh21
Copy link

Environment

System:
    OS: macOS 12.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 95.09 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.17.0 - ~/.nvm/versions/node/v14.17.0/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v14.17.0/bin/yarn
    npm: 6.14.13 - ~/.nvm/versions/node/v14.17.0/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.11.2 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
    Android SDK: Not Found
  IDEs:
    Android Studio: 2021.3 AI-213.7172.25.2113.9123335
    Xcode: 14.0.1/14A400 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.15 - /Library/Java/JavaVirtualMachines/jdk-11.0.15.jdk/Contents/Home/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.1.0 => 18.1.0 
    react-native: 0.70.3 => 0.70.3 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Platforms

Versions

  • Android: N/A
  • iOS: 16.0
  • react-native-dialog: 9.2.2
  • react-native: 0.70.3
  • react: 18.1.0

Description

  • Buttons do not have equal width when another label is shorter

image

Reproducible Demo

@forimbajosh21 forimbajosh21 added the bug Something isn't working label Oct 25, 2022
@mmazzarolo mmazzarolo added the good first issue Good for newcomers label Oct 25, 2022
@mmazzarolo
Copy link
Owner

Ha, good catch! Open for contribution for this issue :)

@kingajohanna
Copy link

just add the width: "50%" to the buildStyles in the button.js file

const buildStyles = (isDark) => StyleSheet.create({ button: Platform.select({ ios: { flexGrow: 1, flexShrink: 1, height: 46, width: '50%', justifyContent: "center", alignItems: "center", },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants