Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return false on start() if can't write to file #5

Open
mmarchini opened this issue Jun 18, 2019 · 0 comments
Open

Return false on start() if can't write to file #5

mmarchini opened this issue Jun 18, 2019 · 0 comments

Comments

@mmarchini
Copy link
Collaborator

Today if we can't write to the file (for example, if the owner of the file is another user) we'll still return true on start(). We should return false instead so users can properly handle this error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmarchini