-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data loader for spam dataset with tests and documentation #1224
Open
Prateek0xeo
wants to merge
2
commits into
mlverse:main
Choose a base branch
from
Prateek0xeo:add-spam-dataloader
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe this PR fits better in https://github.com/mlverse/torchdatasets (I am not the maintainer though, so maybe @dfalbel has a different opinion) |
Thank you, The instructions on
https://github.com/rstats-gsoc/gsoc2025/wiki/torchvision-in-R-improvements
were not clear as it didn't state which repository to fork. Sorry for the
trouble
…On Mon, Dec 30, 2024 at 4:30 PM Sebastian Fischer ***@***.***> wrote:
Maybe this PR is more appropriate in
https://github.com/mlverse/torchdatasets (I am not an official maintainer
though, so maybe @dfalbel <https://github.com/dfalbel> has a different
opinion)
—
Reply to this email directly, view it on GitHub
<#1224 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAG3KFGJPFS5WVRFLPA4YUL2IERTPAVCNFSM6AAAAABUL2E7EWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRVGMZDQMBWHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hello @Prateek0xeo, Many thanks for this contribution ! @sebffischer is right, the perfect place for your P.R. is torchdatasets. |
Sure!
…On Thu, 2 Jan, 2025, 23:24 cregouby, ***@***.***> wrote:
Hello @Prateek0xeo <https://github.com/Prateek0xeo>,
Many thanks for this contribution !
@sebffischer <https://github.com/sebffischer> is right, the perfect place
for your P.R. is torchdatasets <https://github.com/mlverse/torchdatasets>.
Would you be kind enough to make the same P.R. in torchdatasets/pulls
<https://github.com/mlverse/torchdatasets/pulls> ?
—
Reply to this email directly, view it on GitHub
<#1224 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAG3KFDC7MV3BC5ZGXSDUG32IV4MFAVCNFSM6AAAAABUL2E7EWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRYGE2TCMRWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I have completed all the tests. Can I start contributing to torchvision
mlverse/torchvision#104 by implementing datasets
from pytorch https://pytorch.org/vision/stable/datasets.html ?
…On Thu, Jan 2, 2025 at 11:24 PM cregouby ***@***.***> wrote:
Hello @Prateek0xeo <https://github.com/Prateek0xeo>,
Many thanks for this contribution !
@sebffischer <https://github.com/sebffischer> is right, the perfect place
for your P.R. is torchdatasets <https://github.com/mlverse/torchdatasets>.
Would you be kind enough to make the same P.R. in torchdatasets/pulls
<https://github.com/mlverse/torchdatasets/pulls> ?
—
Reply to this email directly, view it on GitHub
<#1224 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAG3KFDC7MV3BC5ZGXSDUG32IV4MFAVCNFSM6AAAAABUL2E7EWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRYGE2TCMRWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new data loader for the spam dataset. The data loader allows users to load the dataset directly into torch for training and testing machine learning models.
Changes Made:
spam_dataset
totorch/datasets
.Issues encountered: