Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$predict should throw an error if PO is not trained #893

Open
mb706 opened this issue Mar 24, 2025 · 0 comments · May be fixed by #897
Open

$predict should throw an error if PO is not trained #893

mb706 opened this issue Mar 24, 2025 · 0 comments · May be fixed by #897
Assignees

Comments

@mb706
Copy link
Collaborator

mb706 commented Mar 24, 2025

Otherwise we get weird error messages when state is unexpectedly NULL.

Weird that we did not have this already.... maybe check if we do have it somewhere else and it does not apply to all pipeops, for some reason? (e.g. we only check in Graph?).

Example:

po("imputeoor")$predict(list(tsk("iris")))
#> Error: Input task during prediction of imputeoor does not match input task during training.

may be a minor breaking change if someone unsed "stateless" POs without training them, before. But this should really not have been allowed to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants