Skip to content

vdb_benchmark: adding AISAQ indexing support#230

Open
ram-sangle wants to merge 2 commits intomlcommons:TF_VDBBenchfrom
ram-sangle:vdb
Open

vdb_benchmark: adding AISAQ indexing support#230
ram-sangle wants to merge 2 commits intomlcommons:TF_VDBBenchfrom
ram-sangle:vdb

Conversation

@ram-sangle
Copy link

  • Updated milvus, etcd and minio versions to support AISAQ as indexing algorithm
  • Added configuration yaml files for AISAQ and DISKANN comparison
  • Added handling for AISAQ indexing parameters
  • README.md update

@ram-sangle ram-sangle requested a review from a team January 27, 2026 06:51
@ram-sangle ram-sangle requested a review from a team as a code owner January 27, 2026 06:51
@github-actions
Copy link

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact support@mlcommons.org.
1 out of 2 committers have signed the MLCommons CLA.
@idevasena
@ram-sangle
You can retrigger this bot by commenting recheck in this Pull Request

@ram-sangle ram-sangle changed the base branch from main to TF_VDBBench January 27, 2026 06:53
@ram-sangle
Copy link
Author

recheck

Copy link

@idevasena idevasena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my end. Everything works.
May be a nit: Since --vector-dim assumes default of 1536, I think we should update README.md for Step 3: Run the benchmark that the cli argument needs to be used when running search phase else it raises MilvusException: vector dimension mismatch.

Updated Run section with --vector-dim parameter usage.
@ram-sangle
Copy link
Author

ram-sangle commented Jan 30, 2026

Thanks @idevasena for trying out the PR. Updated README.md with --vector-dim parameter use.
Working with mlcommons support team to get me added to approved contributors list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants