Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In tvm_runtime.h, there are extra spaces in STRINGIFY_MACRO(EXPAND(n1) EXPAND(n2)). #2618

Closed
XuanqiCui opened this issue Jul 3, 2024 · 1 comment
Closed

In tvm_runtime.h, there are extra spaces in STRINGIFY_MACRO(EXPAND(n1) EXPAND(n2)). #2618

XuanqiCui opened this issue Jul 3, 2024 · 1 comment
Labels
bug Confirmed bugs

Comments

@XuanqiCui
Copy link

馃悰 Bug

To Reproduce

Steps to reproduce the behavior:

WhenBuild Android App from Source, during the Step 2. Build Runtime and Model Libraries, while executing mlc_llm package, there is a chance that a bug will be triggered due to the extra space between EXPAND(n1) and EXPAND(n2) in the #define CONCAT(n1, n2) STRINGIFY_MACRO(EXPAND(n1) EXPAND(n2)) code in tvm_runtime.h. This bug manifests as a space appearing between TVM_SOURCE_DIR and /src/runtime/c_runtime_api.cc when concatenating paths, causing the path to be unrecognizable.
@XuanqiCui XuanqiCui added the bug Confirmed bugs label Jul 3, 2024
@MasterJH5574
Copy link
Collaborator

We fixed this in #2616. Could you update and try again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MasterJH5574 @XuanqiCui