Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken handling when no process.env.SHELL #57

Open
medikoo opened this issue Oct 16, 2019 · 0 comments
Open

Broken handling when no process.env.SHELL #57

medikoo opened this issue Oct 16, 2019 · 0 comments

Comments

@medikoo
Copy link

medikoo commented Oct 16, 2019

Currently implementation relies on process.env.SHELL env var.

It's usually provided, still there can be situation where we work in isolated environment (e.g. for test purposes) and such env var might not be exposed.

Issues I've observed, when no process.env.SHELL is provided:

  • All created scripts have no extension (they just end with a .)
  • uninstall of last registered command crashes, as it tries to read ~/.bashrc and such path needs to be resolved before passing to readFile. It happens because fallback in locationFromShell is not untildified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant