Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up the source code, removing macros and sanitizing names and folders #90

Open
ladislas opened this issue Aug 22, 2017 · 0 comments

Comments

@ladislas
Copy link

Hi there!

First, thank you very much for putting up a project like that! It works incredibly well and is super easy to use.

Recently, I tried to dig deeper into the code and was surprised by the amount of macros that are being used. It makes the code very difficult to read and I guess complicated to make evolve in the future.

I was thinking about trying to refactor a lot of those things and cleaning up stuff a little bit. There are big portions of code that are commented out and it's difficult to know if they are not used anymore at all or if they could be useful in the future.

Is it something you might be interested in? If so, we can discuss the ways to do it and the rules we have to put in place. If not, I'll give it a try on my own I guess.

Best,
-- Ladislas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant