S4MK3: stop wheel led blinking when track is over/stopped #14028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
reviewed
Dec 18, 2024
| const connection1 = engine.makeConnection(this.group, "play", (play) => this.output.bind(this)(engine.getValue(this.group, "playposition"), play)); | ||
| // This is useful for case where effect would have been fully disabled in Mixxx. This appears to be the case during unit tests. | ||
| if (connection1) { | ||
| this.outConnections[0] = connection1; |
There was a problem hiding this comment.
Do I understand this correctly:
this will replace connection0?
|
There's now a small glitch:
|
|
I will look into this when I can |
|
Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13995
Arguably, the code could be slightly cleaner, but I wanted to submit a fix for this before the 2.5 release.
@ronso0 could you please have a look?