Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add independent Formant-Shifting to Pitchshift Effect. #13985

Open
Swiftb0y opened this issue Dec 5, 2024 · 3 comments
Open

Add independent Formant-Shifting to Pitchshift Effect. #13985

Swiftb0y opened this issue Dec 5, 2024 · 3 comments

Comments

@Swiftb0y
Copy link
Member

Swiftb0y commented Dec 5, 2024

Feature Description

Rubberband engines (V3/OptionEngineFiner and RubberBandLiveShifter) have a setFormantScale option which allows for some nice effects without independent of the pitch shifting. It would be nice to have that parameter exposed as another Knob. We currently use 2 of three 3 available knobs for the PitchShiftEffect, this would be a good third candidate. We may need to find another name though that reflects both features better.

Unless we switch to the V3 engine for the Pitchshift effect, #13973 is a prerequisite for this.

CC @davidchocholaty.

@davidchocholaty
Copy link
Contributor

Thank you for the research. Sounds good to me. Keep this in mind when creating the solution for #13973. I agree with adding another knob for this "effect." For clarification, do you think finding another name for the effect itself (so replace the "PitchShiftEffect" name)?

@Swiftb0y
Copy link
Member Author

Swiftb0y commented Dec 7, 2024

I'm not sure. Changing it would make sense because the name no longer accurately reflects the entire feature set, but I don't want to debate what name is best. I think similar audio plugins used in music production are usually referred to as generic "Frequency shifter"s. So I guess we can call it "Frequency Shift Effect" since pitch and formant shifting are both different ways of doing that.

@davidchocholaty
Copy link
Contributor

That sounds reasonable. I like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants